DescriptionReland of Fast-fail to catch VC++ compiler crashes (patchset #1 id:1 of https://codereview.chromium.org/1843783002/ )
Reason for revert:
clang-cl should support this now.
Original issue's description:
> Revert of Fast-fail to catch VC++ compiler crashes (patchset #1 id:1 of https://codereview.chromium.org/1834413002/ )
>
> Reason for revert:
> clang-cl complains about not understanding /d2FastFail. I added it upstream, but we need to roll that in first (or add !is_clang checks here in the meantime if it's important to have this CL in. The description sounds like it could wait a while, though.)
>
> Original issue's description:
> > Fast-fail to catch VC++ compiler crashes
> >
> > The VC++ compiler and linker default to catching their crashes using
> > structure exception handling. They then print out a helpful message.
> > This helpful message is rarely enough information to let us diagnose
> > what went wrong. crrev.com/1816333002 added /fastfail to the linker
> > command line and this adds /d2FastFail to the compiler command line,
> > for gyp and gn.
> >
> > These options are undocumented and unsupported but very handy -
> > the linker /fastfail option was crucial in tracking down a linker
> > crash.
> >
> > Committed: https://crrev.com/10b66c067178bfcfb89b20627f9bb4779ac2efeb
> > Cr-Commit-Position: refs/heads/master@{#383765}
>
> TBR=scottmg@chromium.org,brucedawson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/230c0945ebcba2b566ea5ce953854164d61c1305
> Cr-Commit-Position: refs/heads/master@{#383803}
TBR=scottmg@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Committed: https://crrev.com/8d31432acf8f637b560038b350ee04256cd5fae4
Cr-Commit-Position: refs/heads/master@{#387116}
Patch Set 1 #
Messages
Total messages: 8 (2 generated)
|