Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 188283003: Add ServiceWorkerVersion::status() (which is to be persisted unlike running status) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added more statuses Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version_unittest.cc
diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc
index 18eb8d4f577706b37324930ee7aad8423ffa87da..19ce46b0e1d836b23b76a98ea2e3469d9ec260ae 100644
--- a/content/browser/service_worker/service_worker_version_unittest.cc
+++ b/content/browser/service_worker/service_worker_version_unittest.cc
@@ -136,9 +136,9 @@ TEST_F(ServiceWorkerVersionTest, ConcurrentStartAndStop) {
version_->StartWorker(CreateReceiverOnCurrentThread(&status1));
version_->StartWorker(CreateReceiverOnCurrentThread(&status2));
- EXPECT_EQ(ServiceWorkerVersion::STARTING, version_->status());
+ EXPECT_EQ(ServiceWorkerVersion::STARTING, version_->running_status());
base::RunLoop().RunUntilIdle();
- EXPECT_EQ(ServiceWorkerVersion::RUNNING, version_->status());
+ EXPECT_EQ(ServiceWorkerVersion::RUNNING, version_->running_status());
// Call StartWorker() after it's started.
version_->StartWorker(CreateReceiverOnCurrentThread(&status3));
@@ -159,9 +159,9 @@ TEST_F(ServiceWorkerVersionTest, ConcurrentStartAndStop) {
// Also try calling StartWorker while StopWorker is in queue.
version_->StartWorker(CreateReceiverOnCurrentThread(&status3));
- EXPECT_EQ(ServiceWorkerVersion::STOPPING, version_->status());
+ EXPECT_EQ(ServiceWorkerVersion::STOPPING, version_->running_status());
base::RunLoop().RunUntilIdle();
- EXPECT_EQ(ServiceWorkerVersion::STOPPED, version_->status());
+ EXPECT_EQ(ServiceWorkerVersion::STOPPED, version_->running_status());
// All StopWorker should just succeed, while StartWorker fails.
EXPECT_EQ(SERVICE_WORKER_OK, status1);
@@ -170,7 +170,7 @@ TEST_F(ServiceWorkerVersionTest, ConcurrentStartAndStop) {
}
TEST_F(ServiceWorkerVersionTest, SendMessage) {
- EXPECT_EQ(ServiceWorkerVersion::STOPPED, version_->status());
+ EXPECT_EQ(ServiceWorkerVersion::STOPPED, version_->running_status());
// Send a message without starting the worker.
ServiceWorkerStatusCode status = SERVICE_WORKER_ERROR_FAILED;
@@ -180,7 +180,7 @@ TEST_F(ServiceWorkerVersionTest, SendMessage) {
EXPECT_EQ(SERVICE_WORKER_OK, status);
// The worker should be now started.
- EXPECT_EQ(ServiceWorkerVersion::RUNNING, version_->status());
+ EXPECT_EQ(ServiceWorkerVersion::RUNNING, version_->running_status());
// Stop the worker, and then send the message immediately.
ServiceWorkerStatusCode msg_status = SERVICE_WORKER_ERROR_FAILED;
@@ -197,14 +197,14 @@ TEST_F(ServiceWorkerVersionTest, SendMessage) {
}
TEST_F(ServiceWorkerVersionTest, ReSendMessageAfterStop) {
- EXPECT_EQ(ServiceWorkerVersion::STOPPED, version_->status());
+ EXPECT_EQ(ServiceWorkerVersion::STOPPED, version_->running_status());
// Start the worker.
ServiceWorkerStatusCode start_status = SERVICE_WORKER_ERROR_FAILED;
version_->StartWorker(CreateReceiverOnCurrentThread(&start_status));
base::RunLoop().RunUntilIdle();
EXPECT_EQ(SERVICE_WORKER_OK, start_status);
- EXPECT_EQ(ServiceWorkerVersion::RUNNING, version_->status());
+ EXPECT_EQ(ServiceWorkerVersion::RUNNING, version_->running_status());
// Stop the worker, and then send the message immediately.
ServiceWorkerStatusCode msg_status = SERVICE_WORKER_ERROR_FAILED;
@@ -224,7 +224,7 @@ TEST_F(ServiceWorkerVersionTest, ReSendMessageAfterStop) {
CreateReceiverOnCurrentThread(&msg_status));
base::RunLoop().RunUntilIdle();
EXPECT_EQ(SERVICE_WORKER_OK, msg_status);
- EXPECT_EQ(ServiceWorkerVersion::RUNNING, version_->status());
+ EXPECT_EQ(ServiceWorkerVersion::RUNNING, version_->running_status());
}
TEST_F(ServiceWorkerVersionTest, SendMessageAndRegisterCallback) {

Powered by Google App Engine
This is Rietveld 408576698