content/browser/service_worker/service_worker_storage.h - Issue 188283003: Add ServiceWorkerVersion::status() (which is to be persisted unlike running status)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_storage.h

Issue 188283003: Add ServiceWorkerVersion::status() (which is to be persisted unlike running status) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: build fix after rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_registration_unittest.cc ('k') | content/browser/service_worker/service_worker_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_storage.h

diff --git a/content/browser/service_worker/service_worker_storage.h b/content/browser/service_worker/service_worker_storage.h

index 181f724205f9e872f0a8d9617105d65b2bb4d06e..6dda5a950905b4aa8cbef1629e345da72264acfd 100644

--- a/content/browser/service_worker/service_worker_storage.h

+++ b/content/browser/service_worker/service_worker_storage.h

@@ -56,9 +56,9 @@ class CONTENT_EXPORT ServiceWorkerStorage {

void DeleteRegistration(const GURL& pattern,

const StatusCallback& callback);

- // Returns new registration ID which is guaranteed to be unique in

- // the storage.

+ // Returns new IDs which are guaranteed to be unique in the storage.

int64 NewRegistrationId();

+ int64 NewVersionId();

private:

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerStorageTest, PatternMatches);

@@ -73,6 +73,7 @@ class CONTENT_EXPORT ServiceWorkerStorage {

PatternToRegistrationMap registration_by_pattern_;

int last_registration_id_;

+ int last_version_id_;

scoped_refptr<quota::QuotaManagerProxy> quota_manager_proxy_;

base::FilePath path_;