content/browser/service_worker/service_worker_register_job.cc - Issue 188283003: Add ServiceWorkerVersion::status() (which is to be persisted unlike running status)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 188283003: Add ServiceWorkerVersion::status() (which is to be persisted unlike running status) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: build fix after rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/browser/service_worker/service_worker_registration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_register_job.cc

diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc

index d706968780570336023cf3aeae48d8c1bfb551fa..5b232772053aa1b3846e53baa21d7f836ede350b 100644

--- a/content/browser/service_worker/service_worker_register_job.cc

+++ b/content/browser/service_worker/service_worker_register_job.cc

@@ -111,7 +111,8 @@ void ServiceWorkerRegisterJob::StartWorkerAndContinue(

}

pending_version_ = new ServiceWorkerVersion(

- registration_, worker_registry_, registration_->next_version_id());

+ registration_, worker_registry_,

+ storage_->NewVersionId());

for (std::vector<int>::const_iterator it = pending_process_ids_.begin();

it != pending_process_ids_.end();

++it)

@@ -125,6 +126,7 @@ void ServiceWorkerRegisterJob::StartWorkerAndContinue(

// TODO(alecflett): Don't set the active version until just before

// the activate event is dispatched.

+ pending_version_->set_status(ServiceWorkerVersion::ACTIVE);

registration_->set_active_version(pending_version_);

}