content/browser/service_worker/service_worker_registration_unittest.cc - Issue 188283003: Add ServiceWorkerVersion::status() (which is to be persisted unlike running status)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration_unittest.cc

Issue 188283003: Add ServiceWorkerVersion::status() (which is to be persisted unlike running status) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_register_job.cc ('K') | « content/browser/service_worker/service_worker_registration.cc ('k') | content/browser/service_worker/service_worker_storage.h » ('j') | content/browser/service_worker/service_worker_version.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration_unittest.cc

diff --git a/content/browser/service_worker/service_worker_registration_unittest.cc b/content/browser/service_worker/service_worker_registration_unittest.cc

index 3fb6611a2f3b2b07b8b93da96588206e4fc464bc..c6ad491cb0202ff8b8fa011be260668fe2d06221 100644

--- a/content/browser/service_worker/service_worker_registration_unittest.cc

+++ b/content/browser/service_worker/service_worker_registration_unittest.cc

@@ -35,7 +35,8 @@ TEST_F(ServiceWorkerRegistrationTest, Shutdown) {

registration_id);

scoped_refptr<ServiceWorkerVersion> active_version =

- new ServiceWorkerVersion(registration, NULL, version_id);

+ new ServiceWorkerVersion(registration, NULL, version_id,

+ ServiceWorkerVersion::NEW);

registration->set_active_version(active_version);

registration->Shutdown();

@@ -58,11 +59,13 @@ TEST_F(ServiceWorkerRegistrationTest, ActivatePending) {

const int64 version_1_id = 1L;

const int64 version_2_id = 2L;

scoped_refptr<ServiceWorkerVersion> version_1 =

- new ServiceWorkerVersion(registration, NULL, version_1_id);

+ new ServiceWorkerVersion(registration, NULL, version_1_id,

+ ServiceWorkerVersion::ACTIVE);

registration->set_active_version(version_1);

scoped_refptr<ServiceWorkerVersion> version_2 =

- new ServiceWorkerVersion(registration, NULL, version_2_id);

+ new ServiceWorkerVersion(registration, NULL, version_2_id,

+ ServiceWorkerVersion::NEW);

registration->set_pending_version(version_2);

registration->ActivatePendingVersion();