Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/testing/dart/browser_controller.dart

Issue 1882813002: Delay Firefox browser startup in test scripts, to flatten load. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Increase delay to 10 seconds. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/browser_controller.dart
diff --git a/tools/testing/dart/browser_controller.dart b/tools/testing/dart/browser_controller.dart
index 27765697ea3b74db45fe86f46381cd51199c2df6..7e0b0dfc4b5319b189e4f897456878f8768c575e 100644
--- a/tools/testing/dart/browser_controller.dart
+++ b/tools/testing/dart/browser_controller.dart
@@ -767,7 +767,10 @@ class Firefox extends Browser {
];
var environment = new Map<String, String>.from(Platform.environment);
environment["MOZ_CRASHREPORTER_DISABLE"] = "1";
- return startBrowserProcess(_binary, args, environment: environment);
+ // TODO(26060): Remove delay when dart2js stops hanging under load.
+ return new Future.delayed(new Duration(seconds: 10)).then((_) {
Siggi Cherem (dart-lang) 2016/04/25 18:21:41 since this is only causing issues in windows, can
Bill Hesse 2016/04/26 19:25:08 We only test on linux and windows, and this delay
+ return startBrowserProcess(_binary, args, environment: environment);
+ });
});
}).catchError((e) {
_logEvent("Running $_binary --version failed with $e");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698