Remove SK_VERY_LEGACY_CREATE_TYPEFACE.

src/ports/SkFontHost_fontconfig.cpp

 /*
  * Copyright 2008 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkFontConfigInterface.h"
 #include "SkFontConfigTypeface.h"
 #include "SkFontDescriptor.h"
@@ skipping 148 matching lines @@
         Get().add(face, request);
     }
 
     /** Does not take ownership of request. */
     static SkTypeface* FindAndRef(Request* request) {
         SkAutoMutexAcquire ama(gSkFontHostRequestCacheMutex);
         return Get().findAndRef(request);
     }
 };
 
-#ifdef SK_VERY_LEGACY_CREATE_TYPEFACE
-SkTypeface* FontConfigTypeface::LegacyCreateTypeface(const char requestedFamilyName[],
-                                                     SkTypeface::Style requestedOldStyle)
-{
-    SkFontStyle requestedStyle = SkFontStyle::FromOldStyle(requestedOldStyle);
-#else
 SkTypeface* FontConfigTypeface::LegacyCreateTypeface(const char requestedFamilyName[],
                                                      SkFontStyle requestedStyle)
 {
-#endif
     SkAutoTUnref<SkFontConfigInterface> fci(RefFCI());
     if (nullptr == fci.get()) {
         return nullptr;
     }
 
     // Check if this request is already in the request cache.
     using Request = SkFontHostRequestCache::Request;
     SkAutoTDelete<Request> request(Request::Create(requestedFamilyName, requestedStyle));
     SkTypeface* face = SkFontHostRequestCache::FindAndRef(request);
     if (face) {
         return face;
     }
 
     SkFontConfigInterface::FontIdentity identity;
     SkString outFamilyName;
-#ifdef SK_VERY_LEGACY_CREATE_TYPEFACE
-    SkTypeface::Style outStyle;
-    if (!fci->matchFamilyName(requestedFamilyName, requestedOldStyle,
-#else
     SkFontStyle outStyle;
     if (!fci->matchFamilyName(requestedFamilyName, requestedStyle,
-#endif
                               &identity, &outFamilyName, &outStyle))
     {
         return nullptr;
     }
 
     // Check if a typeface with this FontIdentity is already in the FontIdentity cache.
     face = SkTypefaceCache::FindByProcAndRef(find_by_FontIdentity, &identity);
     if (!face) {
-#ifdef SK_VERY_LEGACY_CREATE_TYPEFACE
-        face = FontConfigTypeface::Create(SkFontStyle::FromOldStyle(outStyle), identity, outFamilyName);
-        // Add this FontIdentity to the FontIdentity cache.
-        SkTypefaceCache::Add(face, SkFontStyle::FromOldStyle(outStyle));
-#else
         face = FontConfigTypeface::Create(outStyle, identity, outFamilyName);
         // Add this FontIdentity to the FontIdentity cache.
         SkTypefaceCache::Add(face, outStyle);
-#endif
     }
     // Add this request to the request cache.
     SkFontHostRequestCache::Add(face, request.release());
 
     return face;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 
 SkStreamAsset* FontConfigTypeface::onOpenStream(int* ttcIndex) const {
@@ skipping 17 matching lines @@
     *familyName = fFamilyName;
 }
 
 void FontConfigTypeface::onGetFontDescriptor(SkFontDescriptor* desc,
                                              bool* isLocalStream) const {
     SkString name;
     this->getFamilyName(&name);
     desc->setFamilyName(name.c_str());
     *isLocalStream = SkToBool(this->getLocalStream());
 }