Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1882803002: Remove SK_VERY_LEGACY_CREATE_TYPEFACE. (Closed)

Created:
4 years, 8 months ago by bungeman-skia
Modified:
4 years, 8 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SK_VERY_LEGACY_CREATE_TYPEFACE. The flag and code it guards are no longer used. TBR=reed This just removes dead code. Committed: https://skia.googlesource.com/skia/+/ed2edabd07086bbf60df17ca0bf52d8ba49f2273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -178 lines) Patch
M gm/fontmgr.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M include/ports/SkFontConfigInterface.h View 1 chunk +0 lines, -8 lines 0 comments Download
M include/ports/SkFontMgr.h View 2 chunks +0 lines, -9 lines 0 comments Download
M include/ports/SkFontMgr_indirect.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkFontMgr.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M src/core/SkTypeface.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M src/fonts/SkFontMgr_fontconfig.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/fonts/SkFontMgr_indirect.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ports/SkFontConfigInterface_direct.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/ports/SkFontConfigInterface_direct.cpp View 5 chunks +1 line, -57 lines 0 comments Download
M src/ports/SkFontConfigTypeface.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ports/SkFontHost_fontconfig.cpp View 3 chunks +0 lines, -18 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ports/SkFontMgr_custom.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ports/SkFontMgr_win_dw.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M tools/sk_tool_utils_font.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882803002/1
4 years, 8 months ago (2016-04-13 12:07:17 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 12:17:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882803002/1
4 years, 8 months ago (2016-04-13 12:22:38 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 12:23:38 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ed2edabd07086bbf60df17ca0bf52d8ba49f2273

Powered by Google App Engine
This is Rietveld 408576698