chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js - Issue 1882793002: Site Settings: Use only string values for permissions on the JS side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

Issue 1882793002: Site Settings: Use only string values for permissions on the JS side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/site_settings/site_details_permission.js ('K') | « chrome/browser/resources/settings/site_settings/site_settings_behavior.js ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

diff --git a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

index 3ba16931c8b26a9e3d8b0ae0f440693cda8e7dc1..d38528d18a3deed339a8e1fa9d3818aa5d3c5b88 100644

--- a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

+++ b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

@@ -78,7 +78,7 @@ cr.define('settings', function() {

* @param {!string} secondaryPattern The embedding origin to change

* (secondary pattern).

* @param {!number} contentType The category to change.

- * @param {!number} value The value to change the permission to.

+ * @param {!string} value The value to change the permission to.

setCategoryPermissionForOrigin: function(

primaryPattern, secondaryPattern, contentType, value) {},