Site Settings: Use only string values for permissions on the JS side.

chrome/browser/resources/settings/site_settings/site_details_permission.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'site-details-permission' handles showing the state of one permission, such
  * as Geolocation, for a given origin.
  */
 Polymer({
@@ skipping 17 matching lines @@
           blockAction: loadTimeData.getString('siteSettingsActionBlock'),
         };
       },
     },
   },
 
   observers: ['siteChanged_(site, category)'],
 
   /** @override */
   attached: function() {
-    this.PermissionStringValues = settings.PermissionStringValues;
+    this.PermissionValues = settings.PermissionValues;
     this.addWebUIListener('contentSettingSitePermissionChanged',
         this.sitePermissionChanged_.bind(this));
   },
 
   /**
    * Sets the site to display.
    * @param {!SiteException} site The site to display.
    * @private
    */
   siteChanged_: function(site) {
@@ skipping 32 matching lines @@
   /**
    * Resets the category permission for this origin.
    */
   resetPermission: function() {
     this.resetCategoryPermissionForOrigin(this.site.origin, '', this.category);
     this.$.details.hidden = true;
   },
 
   /**
    * Handles the category permission changing for this origin.
-   * @param {!{detail: !{item: !{innerText: string}}}} event
+   * @param {!{detail: !{item: !{dataset: !{permissionValue: string}}}}} event
    */
   onPermissionMenuIronActivate_: function(event) {
-    var action = event.detail.item.dataset.permissionValue;
-    var value = '';
-    if (action == settings.PermissionStringValues.ALLOW)
-      value = settings.PermissionValues.ALLOW;
-    else if (action == settings.PermissionStringValues.BLOCK)
-      value = settings.PermissionValues.BLOCK;
-    else
-      assertNotReached('Invalid menu item ' + action);
-
+    var value = event.detail.item.dataset.permissionValue;
     this.setCategoryPermissionForOrigin(
-        this.site.origin, '', value, this.category);
+        this.site.origin, '', this.category, value);
   },
 });