Site Settings: Use only string values for permissions on the JS side.

chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview A helper object used from the "Site Settings" section to
  * interact with the content settings prefs.
  */
 
 /**
@@ skipping 45 matching lines @@
     /**
      * Gets the exceptions (site list) for a particular category.
      * @param {number} contentType The category to change.
      * @return {Promise<Array<SiteException>>}
      */
     getExceptionList: function(contentType) {},
 
     /**
      * Resets the category permission for a given origin (expressed as primary
      *    and secondary patterns).
      * @param {!string} primaryPattern The origin to change (primary pattern).

[tommycli, 2016/04/13 18:21:29]

nit: These primitive types, string, number are non-nullable by default and don't
need the '!' declaration. Just @param {string} is enough.

See https://developers.google.com/closure/compiler/docs/js-for-compiler#types

Here and below

[Finnur, 2016/04/13 21:44:55]

Done!

      * @param {!string} secondaryPattern The embedding origin to change
      *    (secondary pattern).
      * @param {!number} contentType The category to change.
      */
     resetCategoryPermissionForOrigin: function(
         primaryPattern, secondaryPattern, contentType) {},
 
     /**
      * Sets the category permission for a given origin (expressed as primary
      *    and secondary patterns).
      * @param {!string} primaryPattern The origin to change (primary pattern).
      * @param {!string} secondaryPattern The embedding origin to change
      *    (secondary pattern).
      * @param {!number} contentType The category to change.
-     * @param {!number} value The value to change the permission to.
+     * @param {!string} value The value to change the permission to.
      */
     setCategoryPermissionForOrigin: function(
         primaryPattern, secondaryPattern, contentType, value) {},
   };
 
   /**
    * @constructor
    * @implements {SiteSettingsPrefsBrowserProxy}
    */
   function SiteSettingsPrefsBrowserProxyImpl() {}
@@ skipping 30 matching lines @@
         primaryPattern, secondaryPattern, contentType, value) {
       chrome.send('setCategoryPermissionForOrigin',
           [primaryPattern, secondaryPattern, contentType, value]);
     },
   };
 
   return {
     SiteSettingsPrefsBrowserProxyImpl: SiteSettingsPrefsBrowserProxyImpl,
   };
 });