Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: android_webview/native/aw_settings.cc

Issue 1882783002: [WebView] Disallow geolocation on insecure origins for apps targeting N and higher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Torne's comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_settings.cc
diff --git a/android_webview/native/aw_settings.cc b/android_webview/native/aw_settings.cc
index aee8af664954bbdcf70cd3bac4665e436e18224d..85b61aabff4b77c7ceca78c959972b50aa4c6e3f 100644
--- a/android_webview/native/aw_settings.cc
+++ b/android_webview/native/aw_settings.cc
@@ -440,7 +440,8 @@ void AwSettings::PopulateWebPreferencesLocked(JNIEnv* env,
// TODO(jww): This should be removed once sufficient warning has been given of
// possible API breakage because of disabling insecure use of geolocation.
- web_prefs->allow_geolocation_on_insecure_origins = true;
+ web_prefs->allow_geolocation_on_insecure_origins =
+ Java_AwSettings_getAllowGeolocationOnInsecureOrigins(env, obj);
}
static jlong Init(JNIEnv* env,

Powered by Google App Engine
This is Rietveld 408576698