android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java - Issue 1882783002: [WebView] Disallow geolocation on insecure origins for apps targeting N and higher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

Issue 1882783002: [WebView] Disallow geolocation on insecure origins for apps targeting N and higher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/AwSettings.java ('K') | « android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

index d4322266be2d7f4c81a8ef0d646762d018e2e146..f28d1800da6b463a3e9c9ecb2856830039fc16d8 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

@@ -382,7 +382,8 @@ public class AwTestBase

}

public AwSettings createAwSettings(Context context, boolean supportsLegacyQuirks) {

return new AwSettings(context, false /* isAccessFromFileURLsGrantedByDefault */,

- supportsLegacyQuirks, false /* allowEmptyDocumentPersistence */);

+ supportsLegacyQuirks, false /* allowEmptyDocumentPersistence */,

+ true /* allowGeolocationOnInsecureOrigins */);

}