Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1882773003: Make app_mode_app_support a source_set. (Closed)

Created:
4 years, 8 months ago by pcc1
Modified:
4 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make app_mode_app_support a source_set. BUG=603186 R=thakis@chromium.org Committed: https://crrev.com/b06e0b2d518ba42ecc50b773d49a64620b9498ee Cr-Commit-Position: refs/heads/master@{#387098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
pcc1
4 years, 8 months ago (2016-04-13 19:19:10 UTC) #1
Nico
lgtm
4 years, 8 months ago (2016-04-13 19:58:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882773003/1
4 years, 8 months ago (2016-04-13 20:13:10 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/50407)
4 years, 8 months ago (2016-04-13 20:26:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882773003/1
4 years, 8 months ago (2016-04-13 21:03:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 21:25:01 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 21:26:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b06e0b2d518ba42ecc50b773d49a64620b9498ee
Cr-Commit-Position: refs/heads/master@{#387098}

Powered by Google App Engine
This is Rietveld 408576698