Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: runtime/vm/object.cc

Issue 1882763002: Add usage and collision details to the hash table data structure in order to determine effectivenes… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-review-comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/hash_table_test.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 2ce486b3f00f509a8eec81bd2414fcf498e7bfe0..5414c91da0e22a74fdfdf189ce1f1b3dcb95c36e 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -2089,6 +2089,7 @@ class FunctionName {
class ClassFunctionsTraits {
public:
static const char* Name() { return "ClassFunctionsTraits"; }
+ static bool ReportStats() { return false; }
// Called when growing the table.
static bool IsMatch(const Object& a, const Object& b) {
@@ -8333,6 +8334,7 @@ RawTokenStream* TokenStream::New(intptr_t len) {
class CompressedTokenTraits {
public:
static const char* Name() { return "CompressedTokenTraits"; }
+ static bool ReportStats() { return false; }
static bool IsMatch(const Scanner::TokenDescriptor& descriptor,
const Object& key) {
@@ -9263,6 +9265,7 @@ void Library::SetLoadError(const Instance& error) const {
class LibraryUrlTraits {
public:
static const char* Name() { return "LibraryUrlTraits"; }
+ static bool ReportStats() { return false; }
// Called when growing the table.
static bool IsMatch(const Object& a, const Object& b) {
@@ -9574,6 +9577,7 @@ RawObject* Library::ResolveName(const String& name) const {
class StringEqualsTraits {
public:
static const char* Name() { return "StringEqualsTraits"; }
+ static bool ReportStats() { return false; }
static bool IsMatch(const Object& a, const Object& b) {
return String::Cast(a).Equals(String::Cast(b));
@@ -20946,6 +20950,9 @@ const char* GrowableObjectArray::ToCString() const {
// Equivalent to Dart's operator "==" and hashCode.
class DefaultHashTraits {
public:
+ static const char* Name() { return "DefaultHashTraits"; }
+ static bool ReportStats() { return false; }
+
static bool IsMatch(const Object& a, const Object& b) {
if (a.IsNull() || b.IsNull()) {
return (a.IsNull() && b.IsNull());
« no previous file with comments | « runtime/vm/hash_table_test.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698