CC Animation: Make LayerAnimationController to have just one value observer.

cc/animation/layer_animation_controller_unittest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/animation/layer_animation_controller.h"
 
 #include <stddef.h>
 
 #include "base/memory/ptr_util.h"
 #include "cc/animation/animation.h"
@@ skipping 30 matching lines @@
     std::unique_ptr<AnimationCurve> curve,
     int group_id,
     TargetProperty::Type property) {
   return Animation::Create(std::move(curve), 0, group_id, property);
 }
 
 TEST(LayerAnimationControllerTest, SyncNewAnimation) {
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller_impl->SetNeedsActiveValueObservations(true);
 
   EXPECT_FALSE(controller_impl->GetAnimation(TargetProperty::OPACITY));
 
   EXPECT_FALSE(controller->needs_to_start_animations_for_testing());
   EXPECT_FALSE(controller_impl->needs_to_start_animations_for_testing());
 
   int animation_id =
       AddOpacityTransitionToController(controller.get(), 1, 0, 1, false);
   EXPECT_TRUE(controller->needs_to_start_animations_for_testing());
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
   EXPECT_TRUE(controller_impl->needs_to_start_animations_for_testing());
   controller_impl->ActivateAnimations();
 
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id));
   EXPECT_EQ(Animation::WAITING_FOR_TARGET_AVAILABILITY,
             controller_impl->GetAnimationById(animation_id)->run_state());
 }
 
 TEST(LayerAnimationControllerTest,
      SyncScrollOffsetAnimationRespectsHasSetInitialValue) {
   FakeLayerAnimationValueObserver dummy_impl;
   FakeLayerAnimationValueProvider dummy_provider_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
   controller_impl->set_value_provider(&dummy_provider_impl);
+
   FakeLayerAnimationValueObserver dummy;
   FakeLayerAnimationValueProvider dummy_provider;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
   controller->set_value_provider(&dummy_provider);
 
   EXPECT_FALSE(controller_impl->GetAnimation(TargetProperty::SCROLL_OFFSET));
 
   EXPECT_FALSE(controller->needs_to_start_animations_for_testing());
   EXPECT_FALSE(controller_impl->needs_to_start_animations_for_testing());
 
   gfx::ScrollOffset initial_value(100.f, 300.f);
   gfx::ScrollOffset provider_initial_value(150.f, 300.f);
   gfx::ScrollOffset target_value(300.f, 200.f);
@@ skipping 30 matching lines @@
                           ->ToScrollOffsetAnimationCurve()
                           ->GetValue(base::TimeDelta()));
 }
 
 // If an animation is started on the impl thread before it is ticked on the main
 // thread, we must be sure to respect the synchronized start time.
 TEST(LayerAnimationControllerTest, DoNotClobberStartTimes) {
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   EXPECT_FALSE(controller_impl->GetAnimation(TargetProperty::OPACITY));
 
   int animation_id =
       AddOpacityTransitionToController(controller.get(), 1, 0, 1, false);
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
   controller_impl->ActivateAnimations();
 
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id));
@@ skipping 14 matching lines @@
   controller->Animate(kInitialTickTime + TimeDelta::FromMilliseconds(500));
   controller->UpdateState(true, nullptr);
   EXPECT_EQ(controller->GetAnimationById(animation_id)->start_time(),
             controller_impl->GetAnimationById(animation_id)->start_time());
 }
 
 TEST(LayerAnimationControllerTest, UseSpecifiedStartTimes) {
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   int animation_id =
       AddOpacityTransitionToController(controller.get(), 1, 0, 1, false);
 
   const TimeTicks start_time = TicksFromSecondsF(123);
   controller->GetAnimation(TargetProperty::OPACITY)->set_start_time(start_time);
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
   controller_impl->ActivateAnimations();
 
@@ skipping 26 matching lines @@
 // Tests that controllers activate and deactivate as expected.
 TEST(LayerAnimationControllerTest, Activation) {
   std::unique_ptr<AnimationHost> host =
       AnimationHost::Create(ThreadInstance::MAIN);
   std::unique_ptr<AnimationHost> host_impl =
       AnimationHost::Create(ThreadInstance::IMPL);
 
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
+
   std::unique_ptr<AnimationEvents> events = host->CreateEvents();
 
   controller->SetAnimationHost(host.get());
   controller_impl->SetAnimationHost(host_impl.get());
   EXPECT_EQ(1u, host->all_animation_controllers_for_testing().size());
   EXPECT_EQ(1u, host_impl->all_animation_controllers_for_testing().size());
 
   // Initially, both controllers should be inactive.
   EXPECT_EQ(0u, host->active_animation_controllers_for_testing().size());
   EXPECT_EQ(0u, host_impl->active_animation_controllers_for_testing().size());
@@ skipping 55 matching lines @@
   EXPECT_EQ(0u, host_impl->active_animation_controllers_for_testing().size());
 
   controller->SetAnimationHost(nullptr);
   controller_impl->SetAnimationHost(nullptr);
 }
 
 TEST(LayerAnimationControllerTest, SyncPause) {
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   EXPECT_FALSE(controller_impl->GetAnimation(TargetProperty::OPACITY));
 
   // Two steps, three ranges: [0-1) -> 0.2, [1-2) -> 0.3, [2-3] -> 0.4.
   const double duration = 3.0;
   const int animation_id =
       AddOpacityStepsToController(controller.get(), duration, 0.2f, 0.4f, 2);
 
   // Set start offset to be at the beginning of the second range.
   controller->GetAnimationById(animation_id)
@@ skipping 51 matching lines @@
 
   // Opacity value doesn't depend on time if paused at specified time offset.
   EXPECT_EQ(0.4f, dummy.opacity());
   EXPECT_EQ(0.4f, dummy_impl.opacity());
 }
 
 TEST(LayerAnimationControllerTest, DoNotSyncFinishedAnimation) {
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
+
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
 
   EXPECT_FALSE(controller_impl->GetAnimation(TargetProperty::OPACITY));
 
   int animation_id =
       AddOpacityTransitionToController(controller.get(), 1, 0, 1, false);
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
   controller_impl->ActivateAnimations();
@@ skipping 33 matching lines @@
 // main-thread and the impl-thread controllers.
 TEST(LayerAnimationControllerTest, AnimationsAreDeleted) {
   FakeLayerAnimationValueObserver dummy;
   FakeLayerAnimationValueObserver dummy_impl;
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
 
   AddOpacityTransitionToController(controller.get(), 1.0, 0.0f, 1.0f, false);
   controller->Animate(kInitialTickTime);
   controller->UpdateState(true, nullptr);
   controller->PushAnimationUpdatesTo(controller_impl.get());
   controller_impl->ActivateAnimations();
 
   controller_impl->Animate(kInitialTickTime + TimeDelta::FromMilliseconds(500));
   controller_impl->UpdateState(true, events.get());
 
@@ skipping 50 matching lines @@
 
   return event;
 }
 
 TEST(LayerAnimationControllerTest, TrivialTransition) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   std::unique_ptr<Animation> to_add(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
       1, TargetProperty::OPACITY));
 
   EXPECT_FALSE(controller->needs_to_start_animations_for_testing());
   controller->AddAnimation(std::move(to_add));
   EXPECT_TRUE(controller->needs_to_start_animations_for_testing());
   controller->Animate(kInitialTickTime);
   EXPECT_FALSE(controller->needs_to_start_animations_for_testing());
@@ skipping 10 matching lines @@
   event = GetMostRecentPropertyUpdateEvent(events.get());
   EXPECT_FALSE(event);
 }
 
 TEST(LayerAnimationControllerTest, TrivialTransitionOnImpl) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
 
   std::unique_ptr<Animation> to_add(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
       1, TargetProperty::OPACITY));
   to_add->set_is_impl_only(true);
 
   controller_impl->AddAnimation(std::move(to_add));
   controller_impl->Animate(kInitialTickTime);
   controller_impl->UpdateState(true, events.get());
   EXPECT_TRUE(controller_impl->HasActiveAnimation());
@@ skipping 13 matching lines @@
       GetMostRecentPropertyUpdateEvent(events.get());
   EXPECT_EQ(1.f, end_opacity_event->opacity);
 }
 
 TEST(LayerAnimationControllerTest, TrivialTransformOnImpl) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
 
   // Choose different values for x and y to avoid coincidental values in the
   // observed transforms.
   const float delta_x = 3;
   const float delta_y = 4;
 
   std::unique_ptr<KeyframedTransformAnimationCurve> curve(
       KeyframedTransformAnimationCurve::Create());
 
   // Create simple TRANSFORM animation.
@@ skipping 35 matching lines @@
   EXPECT_EQ(expected_transform, end_transform_event->transform);
   EXPECT_TRUE(end_transform_event->is_impl_only);
 }
 
 TEST(LayerAnimationControllerTest, FilterTransition) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   std::unique_ptr<KeyframedFilterAnimationCurve> curve(
       KeyframedFilterAnimationCurve::Create());
 
   FilterOperations start_filters;
   start_filters.Append(FilterOperation::CreateBrightnessFilter(1.f));
   curve->AddKeyframe(
       FilterKeyframe::Create(base::TimeDelta(), start_filters, nullptr));
   FilterOperations end_filters;
   end_filters.Append(FilterOperation::CreateBrightnessFilter(2.f));
@@ skipping 27 matching lines @@
   event = GetMostRecentPropertyUpdateEvent(events.get());
   EXPECT_FALSE(event);
 }
 
 TEST(LayerAnimationControllerTest, FilterTransitionOnImplOnly) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
 
   std::unique_ptr<KeyframedFilterAnimationCurve> curve(
       KeyframedFilterAnimationCurve::Create());
 
   // Create simple FILTER animation.
   FilterOperations start_filters;
   start_filters.Append(FilterOperation::CreateBrightnessFilter(1.f));
   curve->AddKeyframe(
       FilterKeyframe::Create(base::TimeDelta(), start_filters, nullptr));
   FilterOperations end_filters;
@@ skipping 29 matching lines @@
   EXPECT_TRUE(end_filter_event);
   EXPECT_EQ(end_filters, end_filter_event->filters);
   EXPECT_TRUE(end_filter_event->is_impl_only);
 }
 
 TEST(LayerAnimationControllerTest, ScrollOffsetTransition) {
   FakeLayerAnimationValueObserver dummy_impl;
   FakeLayerAnimationValueProvider dummy_provider_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+
   controller_impl->set_value_provider(&dummy_provider_impl);
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   FakeLayerAnimationValueProvider dummy_provider;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
   controller->set_value_provider(&dummy_provider);
 
   gfx::ScrollOffset initial_value(100.f, 300.f);
   gfx::ScrollOffset target_value(300.f, 200.f);
   std::unique_ptr<ScrollOffsetAnimationCurve> curve(
       ScrollOffsetAnimationCurve::Create(target_value,
                                          EaseInOutTimingFunction::Create()));
 
   std::unique_ptr<Animation> animation(
       Animation::Create(std::move(curve), 1, 0, TargetProperty::SCROLL_OFFSET));
@@ skipping 51 matching lines @@
   EXPECT_FALSE(controller->HasActiveAnimation());
 }
 
 // Ensure that when the impl controller doesn't have a value provider,
 // the main-thread controller's value provider is used to obtain the intial
 // scroll offset.
 TEST(LayerAnimationControllerTest, ScrollOffsetTransitionNoImplProvider) {
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   FakeLayerAnimationValueProvider dummy_provider;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
   controller->set_value_provider(&dummy_provider);
 
   gfx::ScrollOffset initial_value(500.f, 100.f);
   gfx::ScrollOffset target_value(300.f, 200.f);
   std::unique_ptr<ScrollOffsetAnimationCurve> curve(
       ScrollOffsetAnimationCurve::Create(target_value,
                                          EaseInOutTimingFunction::Create()));
 
   std::unique_ptr<Animation> animation(
       Animation::Create(std::move(curve), 1, 0, TargetProperty::SCROLL_OFFSET));
@@ skipping 48 matching lines @@
   controller->Animate(kInitialTickTime + duration);
   controller->UpdateState(true, nullptr);
   EXPECT_VECTOR2DF_EQ(target_value, dummy.scroll_offset());
   EXPECT_FALSE(controller->HasActiveAnimation());
 }
 
 TEST(LayerAnimationControllerTest, ScrollOffsetTransitionOnImplOnly) {
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
 
   gfx::ScrollOffset initial_value(100.f, 300.f);
   gfx::ScrollOffset target_value(300.f, 200.f);
   std::unique_ptr<ScrollOffsetAnimationCurve> curve(
       ScrollOffsetAnimationCurve::Create(target_value,
                                          EaseInOutTimingFunction::Create()));
   curve->SetInitialValue(initial_value);
   double duration_in_seconds = curve->Duration().InSecondsF();
@@ skipping 27 matching lines @@
   EXPECT_FALSE(controller_impl->HasActiveAnimation());
   event = GetMostRecentPropertyUpdateEvent(events.get());
   EXPECT_FALSE(event);
 }
 
 TEST(LayerAnimationControllerTest, ScrollOffsetRemovalClearsScrollDelta) {
   FakeLayerAnimationValueObserver dummy_impl;
   FakeLayerAnimationValueProvider dummy_provider_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
   controller_impl->set_value_provider(&dummy_provider_impl);
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   FakeLayerAnimationValueProvider dummy_provider;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
   controller->set_value_provider(&dummy_provider);
 
   // First test the 1-argument version of RemoveAnimation.
   gfx::ScrollOffset target_value(300.f, 200.f);
   std::unique_ptr<ScrollOffsetAnimationCurve> curve(
       ScrollOffsetAnimationCurve::Create(target_value,
                                          EaseInOutTimingFunction::Create()));
 
   int animation_id = 1;
   std::unique_ptr<Animation> animation(Animation::Create(
@@ skipping 126 matching lines @@
   TimeTicks start_time_;
 };
 
 // Tests that impl-only animations lead to start and finished notifications
 // on the impl thread controller's animation delegate.
 TEST(LayerAnimationControllerTest,
      NotificationsForImplOnlyAnimationsAreSentToImplThreadDelegate) {
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeAnimationDelegate delegate;
   controller_impl->set_layer_animation_delegate(&delegate);
 
   std::unique_ptr<Animation> to_add(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
       1, TargetProperty::OPACITY));
   to_add->set_is_impl_only(true);
   controller_impl->AddAnimation(std::move(to_add));
@@ skipping 15 matching lines @@
   EXPECT_TRUE(delegate.started());
   EXPECT_TRUE(delegate.finished());
 }
 
 // Tests that specified start times are sent to the main thread delegate
 TEST(LayerAnimationControllerTest,
      SpecifiedStartTimesAreSentToMainThreadDelegate) {
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
+
   FakeAnimationDelegate delegate;
   controller->set_layer_animation_delegate(&delegate);
 
   int animation_id =
       AddOpacityTransitionToController(controller.get(), 1, 0, 1, false);
 
   const TimeTicks start_time = TicksFromSecondsF(123);
   controller->GetAnimation(TargetProperty::OPACITY)->set_start_time(start_time);
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
@@ skipping 27 matching lines @@
 
  private:
   TimeTicks start_time_;
 };
 
 // Tests that specified start times are sent to the event observers
 TEST(LayerAnimationControllerTest, SpecifiedStartTimesAreSentToEventObservers) {
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
+
   FakeLayerAnimationEventObserver observer;
   controller->AddEventObserver(&observer);
 
   int animation_id =
       AddOpacityTransitionToController(controller.get(), 1, 0, 1, false);
 
   const TimeTicks start_time = TicksFromSecondsF(123);
   controller->GetAnimation(TargetProperty::OPACITY)->set_start_time(start_time);
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
@@ skipping 17 matching lines @@
 
 // Tests animations that are waiting for a synchronized start time do not
 // finish.
 TEST(LayerAnimationControllerTest,
      AnimationsWaitingForStartTimeDoNotFinishIfTheyOutwaitTheirFinish) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   std::unique_ptr<Animation> to_add(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
       1, TargetProperty::OPACITY));
   to_add->set_needs_synchronized_start_time(true);
 
   // We should pause at the first keyframe indefinitely waiting for that
   // animation to start.
   controller->AddAnimation(std::move(to_add));
   controller->Animate(kInitialTickTime);
@@ skipping 19 matching lines @@
   EXPECT_FALSE(controller->HasActiveAnimation());
 }
 
 // Tests that two queued animations affecting the same property run in sequence.
 TEST(LayerAnimationControllerTest, TrivialQueuing) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   EXPECT_FALSE(controller->needs_to_start_animations_for_testing());
 
   controller->AddAnimation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
       1, TargetProperty::OPACITY));
   controller->AddAnimation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 1.f, 0.5f)),
       2, TargetProperty::OPACITY));
 
@@ skipping 21 matching lines @@
   EXPECT_FALSE(controller->HasActiveAnimation());
 }
 
 // Tests interrupting a transition with another transition.
 TEST(LayerAnimationControllerTest, Interrupt) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
+
   controller->AddAnimation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
       1, TargetProperty::OPACITY));
   controller->Animate(kInitialTickTime);
   controller->UpdateState(true, events.get());
   EXPECT_TRUE(controller->HasActiveAnimation());
   EXPECT_EQ(0.f, dummy.opacity());
 
   std::unique_ptr<Animation> to_add(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 1.f, 0.5f)),
@@ skipping 14 matching lines @@
 }
 
 // Tests scheduling two animations to run together when only one property is
 // free.
 TEST(LayerAnimationControllerTest, ScheduleTogetherWhenAPropertyIsBlocked) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   controller->AddAnimation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeTransformTransition(1)), 1,
       TargetProperty::TRANSFORM));
   controller->AddAnimation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeTransformTransition(1)), 2,
       TargetProperty::TRANSFORM));
   controller->AddAnimation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
       2, TargetProperty::OPACITY));
@@ skipping 16 matching lines @@
 
 // Tests scheduling two animations to run together with different lengths and
 // another animation queued to start when the shorter animation finishes (should
 // wait for both to finish).
 TEST(LayerAnimationControllerTest, ScheduleTogetherWithAnAnimWaiting) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   controller->AddAnimation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeTransformTransition(2)), 1,
       TargetProperty::TRANSFORM));
   controller->AddAnimation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
       1, TargetProperty::OPACITY));
   controller->AddAnimation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 1.f, 0.5f)),
       2, TargetProperty::OPACITY));
@@ skipping 20 matching lines @@
   EXPECT_FALSE(controller->HasActiveAnimation());
 }
 
 // Test that a looping animation loops and for the correct number of iterations.
 TEST(LayerAnimationControllerTest, TrivialLooping) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   std::unique_ptr<Animation> to_add(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
       1, TargetProperty::OPACITY));
   to_add->set_iterations(3);
   controller->AddAnimation(std::move(to_add));
 
   controller->Animate(kInitialTickTime);
   controller->UpdateState(true, events.get());
   EXPECT_TRUE(controller->HasActiveAnimation());
@@ skipping 25 matching lines @@
   EXPECT_EQ(1.f, dummy.opacity());
 }
 
 // Test that an infinitely looping animation does indeed go until aborted.
 TEST(LayerAnimationControllerTest, InfiniteLooping) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   std::unique_ptr<Animation> to_add(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
       1, TargetProperty::OPACITY));
   to_add->set_iterations(-1);
   controller->AddAnimation(std::move(to_add));
 
   controller->Animate(kInitialTickTime);
   controller->UpdateState(true, events.get());
   EXPECT_TRUE(controller->HasActiveAnimation());
@@ skipping 26 matching lines @@
   EXPECT_EQ(0.75f, dummy.opacity());
 }
 
 // Test that pausing and resuming work as expected.
 TEST(LayerAnimationControllerTest, PauseResume) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   controller->AddAnimation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
       1, TargetProperty::OPACITY));
 
   controller->Animate(kInitialTickTime);
   controller->UpdateState(true, events.get());
   EXPECT_TRUE(controller->HasActiveAnimation());
   EXPECT_EQ(0.f, dummy.opacity());
   controller->Animate(kInitialTickTime + TimeDelta::FromMilliseconds(500));
@@ skipping 25 matching lines @@
   EXPECT_FALSE(controller->HasActiveAnimation());
   EXPECT_EQ(1.f, dummy.opacity());
 }
 
 TEST(LayerAnimationControllerTest, AbortAGroupedAnimation) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   const int animation_id = 2;
   controller->AddAnimation(Animation::Create(
       std::unique_ptr<AnimationCurve>(new FakeTransformTransition(1)), 1, 1,
       TargetProperty::TRANSFORM));
   controller->AddAnimation(Animation::Create(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(2.0, 0.f, 1.f)),
       animation_id, 1, TargetProperty::OPACITY));
   controller->AddAnimation(Animation::Create(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 1.f, 0.75f)),
@@ skipping 19 matching lines @@
   controller->Animate(kInitialTickTime + TimeDelta::FromMilliseconds(2000));
   controller->UpdateState(true, events.get());
   EXPECT_TRUE(!controller->HasActiveAnimation());
   EXPECT_EQ(0.75f, dummy.opacity());
 }
 
 TEST(LayerAnimationControllerTest, PushUpdatesWhenSynchronizedStartTimeNeeded) {
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   std::unique_ptr<Animation> to_add(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(2.0, 0.f, 1.f)),
       0, TargetProperty::OPACITY));
   to_add->set_needs_synchronized_start_time(true);
   controller->AddAnimation(std::move(to_add));
 
   controller->Animate(kInitialTickTime);
   controller->UpdateState(true, events.get());
   EXPECT_TRUE(controller->HasActiveAnimation());
@@ skipping 11 matching lines @@
             active_animation->run_state());
 }
 
 // Tests that skipping a call to UpdateState works as expected.
 TEST(LayerAnimationControllerTest, SkipUpdateState) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   std::unique_ptr<Animation> first_animation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeTransformTransition(1)), 1,
       TargetProperty::TRANSFORM));
   first_animation->set_is_controlling_instance_for_test(true);
   controller->AddAnimation(std::move(first_animation));
 
   controller->Animate(kInitialTickTime);
   controller->UpdateState(true, events.get());
 
@@ skipping 24 matching lines @@
   // The float tranisition should now be done.
   EXPECT_EQ(1.f, dummy.opacity());
   EXPECT_FALSE(controller->HasActiveAnimation());
 }
 
 // Tests that an animation controller with only a pending observer gets ticked
 // but doesn't progress animations past the STARTING state.
 TEST(LayerAnimationControllerTest, InactiveObserverGetsTicked) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
-  FakeLayerAnimationValueObserver dummy;
-  FakeInactiveLayerAnimationValueObserver pending_dummy;
+  FakeTypedLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
+  controller->SetValueObserver(&dummy);
 
   const int id = 1;
   controller->AddAnimation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.5f, 1.f)),
       id, TargetProperty::OPACITY));
 
   // Without an observer, the animation shouldn't progress to the STARTING
   // state.
   controller->Animate(kInitialTickTime);
   controller->UpdateState(true, events.get());
   EXPECT_EQ(0u, events->events_.size());
   EXPECT_EQ(Animation::WAITING_FOR_TARGET_AVAILABILITY,
             controller->GetAnimation(TargetProperty::OPACITY)->run_state());
 
-  controller->AddValueObserver(&pending_dummy);
+  controller->SetNeedsPendingValueObservations(true);
 
   // With only a pending observer, the animation should progress to the
   // STARTING state and get ticked at its starting point, but should not
   // progress to RUNNING.
   controller->Animate(kInitialTickTime + TimeDelta::FromMilliseconds(1000));
   controller->UpdateState(true, events.get());
   EXPECT_EQ(0u, events->events_.size());
   EXPECT_EQ(Animation::STARTING,
             controller->GetAnimation(TargetProperty::OPACITY)->run_state());
-  EXPECT_EQ(0.5f, pending_dummy.opacity());
+  EXPECT_EQ(0.5f, dummy.opacity(LayerTreeType::PENDING));
 
   // Even when already in the STARTING state, the animation should stay
   // there, and shouldn't be ticked past its starting point.
   controller->Animate(kInitialTickTime + TimeDelta::FromMilliseconds(2000));
   controller->UpdateState(true, events.get());
   EXPECT_EQ(0u, events->events_.size());
   EXPECT_EQ(Animation::STARTING,
             controller->GetAnimation(TargetProperty::OPACITY)->run_state());
-  EXPECT_EQ(0.5f, pending_dummy.opacity());
+  EXPECT_EQ(0.5f, dummy.opacity(LayerTreeType::PENDING));
 
-  controller->AddValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   // Now that an active observer has been added, the animation should still
   // initially tick at its starting point, but should now progress to RUNNING.
   controller->Animate(kInitialTickTime + TimeDelta::FromMilliseconds(3000));
   controller->UpdateState(true, events.get());
   EXPECT_EQ(1u, events->events_.size());
   EXPECT_EQ(Animation::RUNNING,
             controller->GetAnimation(TargetProperty::OPACITY)->run_state());
-  EXPECT_EQ(0.5f, pending_dummy.opacity());
-  EXPECT_EQ(0.5f, dummy.opacity());
+  EXPECT_EQ(0.5f, dummy.opacity(LayerTreeType::PENDING));
+  EXPECT_EQ(0.5f, dummy.opacity(LayerTreeType::ACTIVE));
 
   // The animation should now tick past its starting point.
   controller->Animate(kInitialTickTime + TimeDelta::FromMilliseconds(3500));
-  EXPECT_NE(0.5f, pending_dummy.opacity());
-  EXPECT_NE(0.5f, dummy.opacity());
+  EXPECT_NE(0.5f, dummy.opacity(LayerTreeType::PENDING));
+  EXPECT_NE(0.5f, dummy.opacity(LayerTreeType::ACTIVE));
 }
 
 TEST(LayerAnimationControllerTest, TransformAnimationBounds) {
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
 
   std::unique_ptr<KeyframedTransformAnimationCurve> curve1(
       KeyframedTransformAnimationCurve::Create());
 
   TransformOperations operations1;
@@ skipping 58 matching lines @@
   controller_impl->AddAnimation(std::move(animation));
   EXPECT_FALSE(controller_impl->TransformAnimationBoundsForBox(box, &bounds));
 }
 
 // Tests that AbortAnimations aborts all animations targeting the specified
 // property.
 TEST(LayerAnimationControllerTest, AbortAnimations) {
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   // Start with several animations, and allow some of them to reach the finished
   // state.
   controller->AddAnimation(Animation::Create(
       std::unique_ptr<AnimationCurve>(new FakeTransformTransition(1.0)), 1, 1,
       TargetProperty::TRANSFORM));
   controller->AddAnimation(Animation::Create(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
       2, 2, TargetProperty::OPACITY));
   controller->AddAnimation(Animation::Create(
@@ skipping 26 matching lines @@
   EXPECT_EQ(Animation::ABORTED, controller->GetAnimationById(3)->run_state());
   EXPECT_EQ(Animation::ABORTED, controller->GetAnimationById(4)->run_state());
   EXPECT_EQ(Animation::RUNNING, controller->GetAnimationById(5)->run_state());
 }
 
 // An animation aborted on the main thread should get deleted on both threads.
 TEST(LayerAnimationControllerTest, MainThreadAbortedAnimationGetsDeleted) {
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   int animation_id =
       AddOpacityTransitionToController(controller.get(), 1.0, 0.f, 1.f, false);
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
   controller_impl->ActivateAnimations();
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id));
 
   controller->AbortAnimations(TargetProperty::OPACITY);
   EXPECT_EQ(Animation::ABORTED,
@@ skipping 10 matching lines @@
   controller->PushAnimationUpdatesTo(controller_impl.get());
   EXPECT_FALSE(controller->GetAnimationById(animation_id));
   EXPECT_FALSE(controller_impl->GetAnimationById(animation_id));
 }
 
 // An animation aborted on the impl thread should get deleted on both threads.
 TEST(LayerAnimationControllerTest, ImplThreadAbortedAnimationGetsDeleted) {
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
   FakeAnimationDelegate delegate;
   controller->set_layer_animation_delegate(&delegate);
 
   int animation_id =
       AddOpacityTransitionToController(controller.get(), 1.0, 0.f, 1.f, false);
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
   controller_impl->ActivateAnimations();
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id));
 
@@ skipping 30 matching lines @@
   EXPECT_FALSE(controller->GetAnimationById(animation_id));
   EXPECT_FALSE(controller_impl->GetAnimationById(animation_id));
 }
 
 // Test that an impl-only scroll offset animation that needs to be completed on
 // the main thread gets deleted.
 TEST(LayerAnimationControllerTest, ImplThreadTakeoverAnimationGetsDeleted) {
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
   FakeAnimationDelegate delegate_impl;
   controller_impl->set_layer_animation_delegate(&delegate_impl);
   FakeAnimationDelegate delegate;
   controller->set_layer_animation_delegate(&delegate);
 
   // Add impl-only scroll offset animation.
   int animation_id = 1;
   gfx::ScrollOffset initial_value(100.f, 300.f);
   gfx::ScrollOffset target_value(300.f, 200.f);
   std::unique_ptr<ScrollOffsetAnimationCurve> curve(
@@ skipping 43 matching lines @@
 }
 
 // Ensure that we only generate FINISHED events for animations in a group
 // once all animations in that group are finished.
 TEST(LayerAnimationControllerTest, FinishedEventsForGroup) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
 
   const int group_id = 1;
 
   // Add two animations with the same group id but different durations.
   std::unique_ptr<Animation> first_animation(Animation::Create(
       std::unique_ptr<AnimationCurve>(new FakeTransformTransition(2.0)), 1,
       group_id, TargetProperty::TRANSFORM));
   first_animation->set_is_controlling_instance_for_test(true);
   controller_impl->AddAnimation(std::move(first_animation));
 
@@ skipping 36 matching lines @@
 
 // Ensure that when a group has a mix of aborted and finished animations,
 // we generate a FINISHED event for the finished animation and an ABORTED
 // event for the aborted animation.
 TEST(LayerAnimationControllerTest, FinishedAndAbortedEventsForGroup) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
   FakeLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
 
   // Add two animations with the same group id.
   std::unique_ptr<Animation> first_animation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeTransformTransition(1.0)), 1,
       TargetProperty::TRANSFORM));
   first_animation->set_is_controlling_instance_for_test(true);
   controller_impl->AddAnimation(std::move(first_animation));
 
   std::unique_ptr<Animation> second_animation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
@@ skipping 468 matching lines @@
       LayerAnimationController::ObserverType::PENDING, &max_scale));
   EXPECT_EQ(6.f, max_scale);
   EXPECT_TRUE(controller_impl->MaximumTargetScale(
       LayerAnimationController::ObserverType::ACTIVE, &max_scale));
   EXPECT_EQ(6.f, max_scale);
 }
 
 TEST(LayerAnimationControllerTest, NewlyPushedAnimationWaitsForActivation) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
-  FakeLayerAnimationValueObserver dummy_impl;
-  FakeInactiveLayerAnimationValueObserver pending_dummy_impl;
+  FakeTypedLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
-  controller_impl->AddValueObserver(&pending_dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+  controller_impl->SetNeedsPendingValueObservations(true);
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   EXPECT_FALSE(controller->needs_to_start_animations_for_testing());
   int animation_id =
       AddOpacityTransitionToController(controller.get(), 1, 0.5f, 1.f, false);
   EXPECT_TRUE(controller->needs_to_start_animations_for_testing());
 
   EXPECT_FALSE(controller_impl->needs_to_start_animations_for_testing());
   controller->PushAnimationUpdatesTo(controller_impl.get());
   EXPECT_TRUE(controller_impl->needs_to_start_animations_for_testing());
 
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id));
   EXPECT_EQ(Animation::WAITING_FOR_TARGET_AVAILABILITY,
             controller_impl->GetAnimationById(animation_id)->run_state());
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id)
                   ->affects_pending_observers());
   EXPECT_FALSE(controller_impl->GetAnimationById(animation_id)
                    ->affects_active_observers());
 
   controller_impl->Animate(kInitialTickTime);
   EXPECT_FALSE(controller_impl->needs_to_start_animations_for_testing());
   controller_impl->UpdateState(true, events.get());
 
   // Since the animation hasn't been activated, it should still be STARTING
   // rather than RUNNING.
   EXPECT_EQ(Animation::STARTING,
             controller_impl->GetAnimationById(animation_id)->run_state());
 
   // Since the animation hasn't been activated, only the pending observer
   // should have been ticked.
-  EXPECT_EQ(0.5f, pending_dummy_impl.opacity());
-  EXPECT_EQ(0.f, dummy_impl.opacity());
+  EXPECT_EQ(0.5f, dummy_impl.opacity(LayerTreeType::PENDING));
+  EXPECT_EQ(0.f, dummy_impl.opacity(LayerTreeType::ACTIVE));
 
   controller_impl->ActivateAnimations();
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id)
                   ->affects_pending_observers());
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id)
                   ->affects_active_observers());
 
   controller_impl->Animate(kInitialTickTime +
                            TimeDelta::FromMilliseconds(1000));
   controller_impl->UpdateState(true, events.get());
 
   // Since the animation has been activated, it should have reached the
   // RUNNING state and the active observer should start to get ticked.
   EXPECT_EQ(Animation::RUNNING,
             controller_impl->GetAnimationById(animation_id)->run_state());
-  EXPECT_EQ(0.5f, pending_dummy_impl.opacity());
-  EXPECT_EQ(0.5f, dummy_impl.opacity());
+  EXPECT_EQ(0.5f, dummy_impl.opacity(LayerTreeType::PENDING));
+  EXPECT_EQ(0.5f, dummy_impl.opacity(LayerTreeType::ACTIVE));
 }
 
 TEST(LayerAnimationControllerTest, ActivationBetweenAnimateAndUpdateState) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
-  FakeLayerAnimationValueObserver dummy_impl;
-  FakeInactiveLayerAnimationValueObserver pending_dummy_impl;
+  FakeTypedLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
-  controller_impl->AddValueObserver(&pending_dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+  controller_impl->SetNeedsPendingValueObservations(true);
+
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   int animation_id =
       AddOpacityTransitionToController(controller.get(), 1, 0.5f, 1.f, true);
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
 
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id));
   EXPECT_EQ(Animation::WAITING_FOR_TARGET_AVAILABILITY,
             controller_impl->GetAnimationById(animation_id)->run_state());
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id)
                   ->affects_pending_observers());
   EXPECT_FALSE(controller_impl->GetAnimationById(animation_id)
                    ->affects_active_observers());
 
   controller_impl->Animate(kInitialTickTime);
 
   // Since the animation hasn't been activated, only the pending observer
   // should have been ticked.
-  EXPECT_EQ(0.5f, pending_dummy_impl.opacity());
-  EXPECT_EQ(0.f, dummy_impl.opacity());
+  EXPECT_EQ(0.5f, dummy_impl.opacity(LayerTreeType::PENDING));
+  EXPECT_EQ(0.f, dummy_impl.opacity(LayerTreeType::ACTIVE));
 
   controller_impl->ActivateAnimations();
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id)
                   ->affects_pending_observers());
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id)
                   ->affects_active_observers());
 
   controller_impl->UpdateState(true, events.get());
 
   // Since the animation has been activated, it should have reached the
   // RUNNING state.
   EXPECT_EQ(Animation::RUNNING,
             controller_impl->GetAnimationById(animation_id)->run_state());
 
   controller_impl->Animate(kInitialTickTime + TimeDelta::FromMilliseconds(500));
 
   // Both observers should have been ticked.
-  EXPECT_EQ(0.75f, pending_dummy_impl.opacity());
-  EXPECT_EQ(0.75f, dummy_impl.opacity());
+  EXPECT_EQ(0.75f, dummy_impl.opacity(LayerTreeType::PENDING));
+  EXPECT_EQ(0.75f, dummy_impl.opacity(LayerTreeType::ACTIVE));
 }
 
 TEST(LayerAnimationControllerTest,
      ObserverNotifiedWhenTransformIsPotentiallyAnimatingChanges) {
   AnimationEvents events;
-  FakeLayerAnimationValueObserver active_dummy_impl;
-  FakeInactiveLayerAnimationValueObserver pending_dummy_impl;
+  FakeTypedLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&active_dummy_impl);
-  controller_impl->AddValueObserver(&pending_dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+  controller_impl->SetNeedsPendingValueObservations(true);
+
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   EXPECT_FALSE(dummy.transform_is_animating());
-  EXPECT_FALSE(pending_dummy_impl.transform_is_animating());
-  EXPECT_FALSE(active_dummy_impl.transform_is_animating());
+  EXPECT_FALSE(dummy_impl.transform_is_animating(LayerTreeType::PENDING));
+  EXPECT_FALSE(dummy_impl.transform_is_animating(LayerTreeType::ACTIVE));
 
   // Case 1: An animation that's allowed to run until its finish point.
   AddAnimatedTransformToController(controller.get(), 1.0, 1, 1);
   EXPECT_TRUE(dummy.transform_is_animating());
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
-  EXPECT_TRUE(pending_dummy_impl.transform_is_animating());
-  EXPECT_FALSE(active_dummy_impl.transform_is_animating());
+  EXPECT_TRUE(dummy_impl.transform_is_animating(LayerTreeType::PENDING));
+  EXPECT_FALSE(dummy_impl.transform_is_animating(LayerTreeType::ACTIVE));
 
   controller_impl->ActivateAnimations();
-  EXPECT_TRUE(pending_dummy_impl.transform_is_animating());
-  EXPECT_TRUE(active_dummy_impl.transform_is_animating());
+  EXPECT_TRUE(dummy_impl.transform_is_animating(LayerTreeType::PENDING));
+  EXPECT_TRUE(dummy_impl.transform_is_animating(LayerTreeType::ACTIVE));
 
   controller_impl->Animate(kInitialTickTime);
   controller_impl->UpdateState(true, &events);
 
   controller->NotifyAnimationStarted(events.events_[0]);
   events.events_.clear();
 
   // Finish the animation.
   controller->Animate(kInitialTickTime + TimeDelta::FromMilliseconds(1000));
   controller->UpdateState(true, nullptr);
   EXPECT_FALSE(dummy.transform_is_animating());
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
 
   // controller_impl hasn't yet ticked at/past the end of the animation.
-  EXPECT_TRUE(pending_dummy_impl.transform_is_animating());
-  EXPECT_TRUE(active_dummy_impl.transform_is_animating());
+  EXPECT_TRUE(dummy_impl.transform_is_animating(LayerTreeType::PENDING));
+  EXPECT_TRUE(dummy_impl.transform_is_animating(LayerTreeType::ACTIVE));
 
   controller_impl->Animate(kInitialTickTime +
                            TimeDelta::FromMilliseconds(1000));
   controller_impl->UpdateState(true, &events);
-  EXPECT_FALSE(pending_dummy_impl.transform_is_animating());
-  EXPECT_FALSE(active_dummy_impl.transform_is_animating());
+  EXPECT_FALSE(dummy_impl.transform_is_animating(LayerTreeType::PENDING));
+  EXPECT_FALSE(dummy_impl.transform_is_animating(LayerTreeType::ACTIVE));
 
   controller->NotifyAnimationFinished(events.events_[0]);
   events.events_.clear();
 
   // Case 2: An animation that's removed before it finishes.
   int animation_id =
       AddAnimatedTransformToController(controller.get(), 10.0, 2, 2);
   EXPECT_TRUE(dummy.transform_is_animating());
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
-  EXPECT_TRUE(pending_dummy_impl.transform_is_animating());
-  EXPECT_FALSE(active_dummy_impl.transform_is_animating());
+  EXPECT_TRUE(dummy_impl.transform_is_animating(LayerTreeType::PENDING));
+  EXPECT_FALSE(dummy_impl.transform_is_animating(LayerTreeType::ACTIVE));
 
   controller_impl->ActivateAnimations();
-  EXPECT_TRUE(pending_dummy_impl.transform_is_animating());
-  EXPECT_TRUE(active_dummy_impl.transform_is_animating());
+  EXPECT_TRUE(dummy_impl.transform_is_animating(LayerTreeType::PENDING));
+  EXPECT_TRUE(dummy_impl.transform_is_animating(LayerTreeType::ACTIVE));
 
   controller_impl->Animate(kInitialTickTime +
                            TimeDelta::FromMilliseconds(2000));
   controller_impl->UpdateState(true, &events);
 
   controller->NotifyAnimationStarted(events.events_[0]);
   events.events_.clear();
 
   controller->RemoveAnimation(animation_id);
   EXPECT_FALSE(dummy.transform_is_animating());
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
-  EXPECT_FALSE(pending_dummy_impl.transform_is_animating());
-  EXPECT_TRUE(active_dummy_impl.transform_is_animating());
+  EXPECT_FALSE(dummy_impl.transform_is_animating(LayerTreeType::PENDING));
+  EXPECT_TRUE(dummy_impl.transform_is_animating(LayerTreeType::ACTIVE));
 
   controller_impl->ActivateAnimations();
-  EXPECT_FALSE(pending_dummy_impl.transform_is_animating());
-  EXPECT_FALSE(active_dummy_impl.transform_is_animating());
+  EXPECT_FALSE(dummy_impl.transform_is_animating(LayerTreeType::PENDING));
+  EXPECT_FALSE(dummy_impl.transform_is_animating(LayerTreeType::ACTIVE));
 
   // Case 3: An animation that's aborted before it finishes.
   animation_id = AddAnimatedTransformToController(controller.get(), 10.0, 3, 3);
   EXPECT_TRUE(dummy.transform_is_animating());
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
-  EXPECT_TRUE(pending_dummy_impl.transform_is_animating());
-  EXPECT_FALSE(active_dummy_impl.transform_is_animating());
+  EXPECT_TRUE(dummy_impl.transform_is_animating(LayerTreeType::PENDING));
+  EXPECT_FALSE(dummy_impl.transform_is_animating(LayerTreeType::ACTIVE));
 
   controller_impl->ActivateAnimations();
-  EXPECT_TRUE(pending_dummy_impl.transform_is_animating());
-  EXPECT_TRUE(active_dummy_impl.transform_is_animating());
+  EXPECT_TRUE(dummy_impl.transform_is_animating(LayerTreeType::PENDING));
+  EXPECT_TRUE(dummy_impl.transform_is_animating(LayerTreeType::ACTIVE));
 
   controller_impl->Animate(kInitialTickTime +
                            TimeDelta::FromMilliseconds(3000));
   controller_impl->UpdateState(true, &events);
 
   controller->NotifyAnimationStarted(events.events_[0]);
   events.events_.clear();
 
   controller_impl->AbortAnimations(TargetProperty::TRANSFORM);
-  EXPECT_FALSE(pending_dummy_impl.transform_is_animating());
-  EXPECT_FALSE(active_dummy_impl.transform_is_animating());
+  EXPECT_FALSE(dummy_impl.transform_is_animating(LayerTreeType::PENDING));
+  EXPECT_FALSE(dummy_impl.transform_is_animating(LayerTreeType::ACTIVE));
 
   controller_impl->Animate(kInitialTickTime +
                            TimeDelta::FromMilliseconds(4000));
   controller_impl->UpdateState(true, &events);
 
   controller->NotifyAnimationAborted(events.events_[0]);
   EXPECT_FALSE(dummy.transform_is_animating());
 }
 
 TEST(LayerAnimationControllerTest, ClippedOpacityValues) {
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   AddOpacityTransitionToController(controller.get(), 1, 1.f, 2.f, true);
 
   controller->Animate(kInitialTickTime);
   EXPECT_EQ(1.f, dummy.opacity());
 
   // Opacity values are clipped [0,1]
   controller->Animate(kInitialTickTime + TimeDelta::FromMilliseconds(1000));
   EXPECT_EQ(1.f, dummy.opacity());
 }
 
 TEST(LayerAnimationControllerTest, ClippedNegativeOpacityValues) {
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   AddOpacityTransitionToController(controller.get(), 1, 0.f, -2.f, true);
 
   controller->Animate(kInitialTickTime);
   EXPECT_EQ(0.f, dummy.opacity());
 
   // Opacity values are clipped [0,1]
   controller->Animate(kInitialTickTime + TimeDelta::FromMilliseconds(1000));
   EXPECT_EQ(0.f, dummy.opacity());
 }
 
 TEST(LayerAnimationControllerTest, PushedDeletedAnimationWaitsForActivation) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
-  FakeLayerAnimationValueObserver dummy_impl;
-  FakeInactiveLayerAnimationValueObserver pending_dummy_impl;
+  FakeTypedLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
-  controller_impl->AddValueObserver(&pending_dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+  controller_impl->SetNeedsPendingValueObservations(true);
+
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   int animation_id =
       AddOpacityTransitionToController(controller.get(), 1, 0.5f, 1.f, true);
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
   controller_impl->ActivateAnimations();
   controller_impl->Animate(kInitialTickTime);
   controller_impl->UpdateState(true, events.get());
   EXPECT_EQ(Animation::RUNNING,
             controller_impl->GetAnimationById(animation_id)->run_state());
-  EXPECT_EQ(0.5f, pending_dummy_impl.opacity());
-  EXPECT_EQ(0.5f, dummy_impl.opacity());
+  EXPECT_EQ(0.5f, dummy_impl.opacity(LayerTreeType::PENDING));
+  EXPECT_EQ(0.5f, dummy_impl.opacity(LayerTreeType::ACTIVE));
 
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id)
                   ->affects_pending_observers());
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id)
                   ->affects_active_observers());
 
   // Delete the animation on the main-thread controller.
   controller->RemoveAnimation(
       controller->GetAnimation(TargetProperty::OPACITY)->id());
   controller->PushAnimationUpdatesTo(controller_impl.get());
 
   // The animation should no longer affect pending observers.
   EXPECT_FALSE(controller_impl->GetAnimationById(animation_id)
                    ->affects_pending_observers());
   EXPECT_TRUE(controller_impl->GetAnimationById(animation_id)
                   ->affects_active_observers());
 
   controller_impl->Animate(kInitialTickTime + TimeDelta::FromMilliseconds(500));
   controller_impl->UpdateState(true, events.get());
 
   // Only the active observer should have been ticked.
-  EXPECT_EQ(0.5f, pending_dummy_impl.opacity());
-  EXPECT_EQ(0.75f, dummy_impl.opacity());
+  EXPECT_EQ(0.5f, dummy_impl.opacity(LayerTreeType::PENDING));
+  EXPECT_EQ(0.75f, dummy_impl.opacity(LayerTreeType::ACTIVE));
 
   controller_impl->ActivateAnimations();
 
   // Activation should cause the animation to be deleted.
   EXPECT_FALSE(controller_impl->has_any_animation());
 }
 
 // Tests that an animation that affects only active observers won't block
 // an animation that affects only pending observers from starting.
 TEST(LayerAnimationControllerTest, StartAnimationsAffectingDifferentObservers) {
   std::unique_ptr<AnimationEvents> events(
       base::WrapUnique(new AnimationEvents));
-  FakeLayerAnimationValueObserver dummy_impl;
-  FakeInactiveLayerAnimationValueObserver pending_dummy_impl;
+  FakeTypedLayerAnimationValueObserver dummy_impl;
   scoped_refptr<LayerAnimationController> controller_impl(
       LayerAnimationController::Create(0));
-  controller_impl->AddValueObserver(&dummy_impl);
-  controller_impl->AddValueObserver(&pending_dummy_impl);
+  controller_impl->SetValueObserver(&dummy_impl);
+  controller_impl->SetNeedsActiveValueObservations(true);
+  controller_impl->SetNeedsPendingValueObservations(true);
+
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   int first_animation_id =
       AddOpacityTransitionToController(controller.get(), 1, 0.f, 1.f, true);
 
   controller->PushAnimationUpdatesTo(controller_impl.get());
   controller_impl->ActivateAnimations();
   controller_impl->Animate(kInitialTickTime);
   controller_impl->UpdateState(true, events.get());
 
   // Remove the first animation from the main-thread controller, and add a
@@ skipping 21 matching lines @@
   // The original animation should still be running, and the new animation
   // should be starting.
   EXPECT_EQ(Animation::RUNNING,
             controller_impl->GetAnimationById(first_animation_id)->run_state());
   EXPECT_EQ(
       Animation::STARTING,
       controller_impl->GetAnimationById(second_animation_id)->run_state());
 
   // The active observer should have been ticked by the original animation,
   // and the pending observer should have been ticked by the new animation.
-  EXPECT_EQ(1.f, pending_dummy_impl.opacity());
-  EXPECT_EQ(0.5f, dummy_impl.opacity());
+  EXPECT_EQ(1.f, dummy_impl.opacity(LayerTreeType::PENDING));
+  EXPECT_EQ(0.5f, dummy_impl.opacity(LayerTreeType::ACTIVE));
 
   controller_impl->ActivateAnimations();
 
   // The original animation should have been deleted, and the new animation
   // should now affect both observers.
   EXPECT_FALSE(controller_impl->GetAnimationById(first_animation_id));
   EXPECT_TRUE(controller_impl->GetAnimationById(second_animation_id)
                   ->affects_pending_observers());
   EXPECT_TRUE(controller_impl->GetAnimationById(second_animation_id)
                   ->affects_active_observers());
 
   controller_impl->Animate(kInitialTickTime +
                            TimeDelta::FromMilliseconds(1000));
   controller_impl->UpdateState(true, events.get());
 
   // The new animation should be running, and the active observer should have
   // been ticked at the new animation's starting point.
   EXPECT_EQ(
       Animation::RUNNING,
       controller_impl->GetAnimationById(second_animation_id)->run_state());
-  EXPECT_EQ(1.f, pending_dummy_impl.opacity());
-  EXPECT_EQ(1.f, dummy_impl.opacity());
+  EXPECT_EQ(1.f, dummy_impl.opacity(LayerTreeType::PENDING));
+  EXPECT_EQ(1.f, dummy_impl.opacity(LayerTreeType::ACTIVE));
 }
 
 TEST(LayerAnimationControllerTest, TestIsCurrentlyAnimatingProperty) {
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   // Create an animation that initially affects only pending observers.
   std::unique_ptr<Animation> animation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
       1, TargetProperty::OPACITY));
   animation->set_affects_active_observers(false);
 
   controller->AddAnimation(std::move(animation));
   controller->Animate(kInitialTickTime);
   EXPECT_TRUE(controller->IsCurrentlyAnimatingProperty(
@@ skipping 55 matching lines @@
   EXPECT_FALSE(controller->IsCurrentlyAnimatingProperty(
       TargetProperty::FILTER, LayerAnimationController::ObserverType::ACTIVE));
 
   EXPECT_EQ(1.f, dummy.opacity());
 }
 
 TEST(LayerAnimationControllerTest, TestIsAnimatingPropertyTimeOffsetFillMode) {
   FakeLayerAnimationValueObserver dummy;
   scoped_refptr<LayerAnimationController> controller(
       LayerAnimationController::Create(0));
-  controller->AddValueObserver(&dummy);
+  controller->SetValueObserver(&dummy);
+  controller->SetNeedsActiveValueObservations(true);
 
   // Create an animation that initially affects only pending observers, and has
   // a start delay of 2 seconds.
   std::unique_ptr<Animation> animation(CreateAnimation(
       std::unique_ptr<AnimationCurve>(new FakeFloatTransition(1.0, 0.f, 1.f)),
       1, TargetProperty::OPACITY));
   animation->set_fill_mode(Animation::FILL_MODE_NONE);
   animation->set_time_offset(TimeDelta::FromMilliseconds(-2000));
   animation->set_affects_active_observers(false);
 
@@ skipping 66 matching lines @@
       TargetProperty::OPACITY, LayerAnimationController::ObserverType::ACTIVE));
   EXPECT_FALSE(controller->IsCurrentlyAnimatingProperty(
       TargetProperty::OPACITY,
       LayerAnimationController::ObserverType::PENDING));
   EXPECT_FALSE(controller->IsCurrentlyAnimatingProperty(
       TargetProperty::OPACITY, LayerAnimationController::ObserverType::ACTIVE));
 }
 
 }  // namespace
 }  // namespace cc