Issue 1882673002: Roll ICU to c291cde2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1882673002: Roll ICU to c291cde2. (Closed)

Created:
4 years, 8 months ago by Lei Zhang

Modified:
4 years, 8 months ago

Reviewers:
jungshik at Google

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

More Reviews

Description

Roll ICU to c291cde2. Committed: https://pdfium.googlesource.com/pdfium/+/f1accf62715942e3f833fa57d0e6e1b70f51bae6

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jungshik at Google

LGTM I was confused at first NOT realizing that this is for pdfium :-) Thank ...

4 years, 8 months ago (2016-04-12 23:50:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882673002/1

4 years, 8 months ago (2016-04-12 23:54:42 UTC) #5

commit-bot: I haz the power

4 years, 8 months ago (2016-04-12 23:54:59 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/f1accf62715942e3f833fa57d0e6e1b70f51...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages