Issue 1882633002: Clean up reporting HintCode.UNUSED_SHOWN_NAME when a prefixed top-level function is invoked.

Issue 1882633002: Clean up reporting HintCode.UNUSED_SHOWN_NAME when a prefixed top-level function is invoked. (Closed)

Created:
4 years, 8 months ago by scheglov

Modified:
4 years, 8 months ago

Reviewers:
srawlins, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Clean up reporting HintCode.UNUSED_SHOWN_NAME when a prefixed top-level function is invoked. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1075e3a32ea731c2b0e85b6923eea21534bc1012

Created: 4 years, 8 months ago

		Unified diffs	Side-by-side diffs	Stats (+103 lines, -67 lines)
	M	pkg/analyzer/lib/src/generated/resolver.dart	View	10 chunks	+79 lines, -67 lines	0 comments
	M	pkg/analyzer/test/generated/non_hint_code_test.dart	View	1 chunk	+24 lines, -0 lines	0 comments

Total messages: 7 (2 generated)

scheglov

Committed patchset #2 (id:20001) manually as 1075e3a32ea731c2b0e85b6923eea21534bc1012 (presubmit successful).

4 years, 8 months ago (2016-04-12 20:31:44 UTC) #4

scheglov

On 2016/04/12 20:28:20, Brian Wilkerson wrote: > lgtm, but maybe add a test? Yes, good ...

4 years, 8 months ago (2016-04-12 20:32:28 UTC) #5

Message was sent while issue was closed.

Thanks much!!!