Chromium Code Reviews Chromium Code Reviews
Issue 1882603003:
[Chromedriver] Add testcase for testing alert on new window. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/test/chromedriver/test/run_py_tests.py |
| diff --git a/chrome/test/chromedriver/test/run_py_tests.py b/chrome/test/chromedriver/test/run_py_tests.py |
| index 279e474d65e3c098c985714077888075668d0f32..2b66209be3e73ac0215dc21a14a73b4af5fb8a1c 100755 |
| --- a/chrome/test/chromedriver/test/run_py_tests.py |
| +++ b/chrome/test/chromedriver/test/run_py_tests.py |
| @@ -59,6 +59,8 @@ _NEGATIVE_FILTER = [ |
| # crbug.com/469947 |
| 'ChromeDriverTest.testTouchPinch', |
| 'ChromeDriverTest.testReturningAFunctionInJavascript', |
| + # https://bugs.chromium.org/p/chromedriver/issues/detail?id=833 |
| + 'ChromeDriverTest.testAlertOnNewWindow', |
| ] |
| _VERSION_SPECIFIC_FILTER = {} |
| @@ -714,6 +716,25 @@ class ChromeDriverTest(ChromeDriverBaseTest): |
| self.assertEquals(False, |
| self._driver.ExecuteScript('return window.confirmed')) |
| + def testAlertOnNewWindow(self): |
| + self._http_server.SetDataForPath( |
| + '/newwindowWithAlert', |
| + """ |
| + <html> |
| + <body> |
| + <a href='%s' target='_blank'>new window having alert onload</a> |
| + </body> |
| + </html>""" % self.GetHttpUrlForFile('/chromedriver/alert_onload.html')) |
| + self._driver.Load(self._http_server.GetUrl() + '/newwindowWithAlert') |
|
samuong
2017/03/27 18:22:06
i'd suggest just loading about:blank, and then set
gmanikpure
2017/03/27 20:38:38
I get 'element not visible error' at line730 when
|
| + old_windows = self._driver.GetWindowHandles() |
| + self._driver.FindElement('tagName', 'a').Click() |
| + new_window = self.WaitForNewWindow(self._driver, old_windows) |
| + self.assertNotEqual(None, new_window) |
| + self._driver.SwitchToWindow(new_window) |
| + self.assertTrue(self._driver.IsAlertOpen()) |
| + self._driver.HandleAlert(False) |
| + self.assertFalse(self._driver.IsAlertOpen()) |
| + |
| def testShouldHandleNewWindowLoadingProperly(self): |
| """Tests that ChromeDriver determines loading correctly for new windows.""" |
| self._http_server.SetDataForPath( |
