Telemetry / Android: symbolize crashstack.

tools/telemetry/telemetry/page/page_runner.py

Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index 9ec2d348dc654ad955b6ad52f8ae083897ba6601..618894e4ef6e2f31a9c35b1f7d9dca1c79786d2a 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -235,7 +235,7 @@ def Run(test, page_set, options):
             _CheckThermalThrottling(state.browser.platform)
           except exceptions.TabCrashException:
             stdout = ''
-            if not options.show_stdout:

[tonyg, 2013/07/12 15:33:30]

That was weird

[bulach, 2013/07/12 15:51:27]

:)

[tonyg, 2013/07/12 22:52:41]

Sorry, I realized why this was there now. The idea is that if you are already
running with --show-stdout, then you don't need to call GetStandardOutput()
because the stdout is already being output.

This block specifically says, even if you are not using --show-stdout, we want
to show it in the case of a tab crash.

Since the bots do not pass --show-stdout, with this change we'll never output
stacks on the bots.

The easiest thing to do is probably just to put it back the way it was. The
right thing to do is probably to separate out functions for GetStandardOutput()
and GetStackTrace() instead of misusing GetStandardOutput() on android.

+            if options.show_stdout:
               stdout = state.browser.GetStandardOutput()
               stdout = (('\nStandard Output:\n') +
                         ('*' * 80) +