Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 18826008: Fix plot script. (Closed)

Created:
7 years, 5 months ago by Yang
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix plot script. The script for the time line plot has been broken since r15484, which changed the format of tick entries in v8.log. To prevent this from happening in the future, I added a test case. R=hpayer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15581

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4224 lines, -40 lines) Patch
A + test/mjsunit/tools/profviz.js View 1 chunk +43 lines, -38 lines 2 comments Download
A test/mjsunit/tools/profviz-test.default View 1 chunk +1566 lines, -0 lines 0 comments Download
A test/mjsunit/tools/profviz-test.log View 1 chunk +2613 lines, -0 lines 0 comments Download
M tools/profviz/composer.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yang
7 years, 5 months ago (2013-07-09 09:36:39 UTC) #1
Yang
On 2013/07/09 09:36:39, Yang wrote: Review guidance: - I changed tools/profviz/composer.js to reflect the changes ...
7 years, 5 months ago (2013-07-09 09:39:24 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/18826008/diff/1/test/mjsunit/tools/profviz.js File test/mjsunit/tools/profviz.js (right): https://codereview.chromium.org/18826008/diff/1/test/mjsunit/tools/profviz.js#newcode78 test/mjsunit/tools/profviz.js:78: if (create_baseline) { looks like create_baseline is always false? ...
7 years, 5 months ago (2013-07-10 07:31:50 UTC) #3
Hannes Payer (out of office)
One more comment... https://codereview.chromium.org/18826008/diff/1/test/mjsunit/tools/profviz.js File test/mjsunit/tools/profviz.js (right): https://codereview.chromium.org/18826008/diff/1/test/mjsunit/tools/profviz.js#newcode74 test/mjsunit/tools/profviz.js:74: output("# objects: " + objects); would ...
7 years, 5 months ago (2013-07-10 07:37:24 UTC) #4
Hannes Payer (out of office)
LGTM
7 years, 5 months ago (2013-07-10 07:47:25 UTC) #5
Yang
7 years, 5 months ago (2013-07-10 07:53:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r15581 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698