Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 1882583004: Updates for ongoing webrtc VideoFrame refactoring. (Closed)

Created:
4 years, 8 months ago by nisse-chromium (ooo August 14)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updates for ongoing webrtc VideoFrame refactoring. Use .video_frame_buffer()->native_handle(). Update for method rename, GetWidth --> width, GetHeight --> height. BUG=webrtc:5682 Committed: https://crrev.com/7e9ca994dd4c34f2d7311f7a5de089193b2245a5 Cr-Commit-Position: refs/heads/master@{#387248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M content/renderer/media/rtc_video_encoder.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/webrtc_video_renderer_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
nisse-chromium (ooo August 14)
4 years, 8 months ago (2016-04-13 11:10:35 UTC) #2
perkj_chrome
On 2016/04/13 11:10:35, nisse-chromium wrote: lgtm
4 years, 8 months ago (2016-04-13 11:44:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882583004/1
4 years, 8 months ago (2016-04-13 12:36:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/168025)
4 years, 8 months ago (2016-04-13 12:46:08 UTC) #7
nisse-chromium (ooo August 14)
Hi, please have a look.
4 years, 8 months ago (2016-04-13 13:05:59 UTC) #9
Sergey Ulanov
lgtm
4 years, 8 months ago (2016-04-13 20:09:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882583004/1
4 years, 8 months ago (2016-04-14 06:32:54 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 06:37:37 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 06:38:52 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e9ca994dd4c34f2d7311f7a5de089193b2245a5
Cr-Commit-Position: refs/heads/master@{#387248}

Powered by Google App Engine
This is Rietveld 408576698