Gerrit git cl upload: add check for missing credentials.

gerrit_util.py

 # Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 Utilities for requesting information for a gerrit server via https.
 
 https://gerrit-review.googlesource.com/Documentation/rest-api.html
 """
 
@@ skipping 65 matching lines @@
 
   @staticmethod
   def get():
     """Returns: (Authenticator) The identified Authenticator to use.
 
     Probes the local system and its environment and identifies the
     Authenticator instance to use.
     """
     if GceAuthenticator.is_gce():
       return GceAuthenticator()
-    return NetrcAuthenticator()
+    return CookiesAuthenticator()
 
 
-class NetrcAuthenticator(Authenticator):
-  """Authenticator implementation that uses ".netrc" for token.
+class CookiesAuthenticator(Authenticator):
+  """Authenticator implementation that uses ".netrc" or ".gitcookies" for token.
+
+  Expected case for developer workstations.
   """
 
   def __init__(self):
     self.netrc = self._get_netrc()
     self.gitcookies = self._get_gitcookies()
 
-  @staticmethod
-  def _get_netrc():
+  @classmethod
+  def get_new_password_message(cls, host):
+    # Assume *.googlesource.com pattern.
+    parts = host.split('.')
+    if not parts[0].endswith('-review'):
+      parts[0] = parts[0] + '-review'

[Michael Achenbach, 2016/04/13 10:29:13]

I'm a fan of
parts[0] += '-review'
up to you

[Paweł Hajdan Jr., 2016/04/13 11:41:52]

+1

[tandrii(chromium), 2016/04/13 11:55:58]

Done.

+    url = 'https://%s/new-password' % ('.'.join(parts))

[Michael Achenbach, 2016/04/13 10:29:13]

Maybe
assert not host.startswith('http')

I know it doesn't, but an assert makes the invariants clearer.

+    return 'You can (re)generate your credentails by visiting %s' % url
+
+  @classmethod
+  def get_netrc_path(cls):
     path = '_netrc' if sys.platform.startswith('win') else '.netrc'
-    path = os.path.expanduser(os.path.join('~', path))
+    return os.path.expanduser(os.path.join('~', path))
+
+  @classmethod
+  def _get_netrc(cls):
+    path = cls.get_netrc_path()
+    if not os.path.exists(path):
+      return netrc.netrc(os.devnull)
+
     try:
       return netrc.netrc(path)
     except IOError:
       print >> sys.stderr, 'WARNING: Could not read netrc file %s' % path
       return netrc.netrc(os.devnull)
-    except netrc.NetrcParseError as e:
-      st = os.stat(e.path)
+    except netrc.NetrcParseError:
+      st = os.stat(path)
       if st.st_mode & (stat.S_IRWXG | stat.S_IRWXO):
         print >> sys.stderr, (
             'WARNING: netrc file %s cannot be used because its file '
             'permissions are insecure.  netrc file permissions should be '
             '600.' % path)
       else:
         print >> sys.stderr, ('ERROR: Cannot use netrc file %s due to a '
                               'parsing error.' % path)
         raise
       return netrc.netrc(os.devnull)
 
-  @staticmethod
-  def _get_gitcookies():
+  @classmethod
+  def get_gitcookies_path(cls):
+    return os.path.join(os.environ['HOME'], '.gitcookies')
+
+  @classmethod
+  def _get_gitcookies(cls):
     gitcookies = {}
-    path = os.path.join(os.environ['HOME'], '.gitcookies')
+    path = cls.get_gitcookies_path()
+    if not os.path.exists(path):
+      return gitcookies
+
     try:
       f = open(path, 'rb')
     except IOError:
       return gitcookies
 
     with f:
       for line in f:
         try:
           fields = line.strip().split('\t')
           if line.strip().startswith('#') or len(fields) != 7:
@@ skipping 13 matching lines @@
       if cookielib.domain_match(host, domain):
         auth = (creds[0], None, creds[1])
         break
 
     if not auth:
       auth = self.netrc.authenticators(host)
     if auth:
       return 'Basic %s' % (base64.b64encode('%s:%s' % (auth[0], auth[2])))
     return None
 
+# Backwards compatibility just in case somebody imports this outside of
+# depot_tools.
+NetrcAuthenticator = CookiesAuthenticator

[Michael Achenbach, 2016/04/13 10:29:13]

Optional: Maybe let the NetrcAuthenticator print a deprecation warning on
creation? Of course even printing might break people.

[tandrii(chromium), 2016/04/13 11:55:58]

skipping because depot_tool will always be now a collection of (deprecated ||
broken) stuff.

+
 
 class GceAuthenticator(Authenticator):
   """Authenticator implementation that uses GCE metadata service for token.
   """
 
   _INFO_URL = 'http://metadata.google.internal'
   _ACQUIRE_URL = ('http://metadata/computeMetadata/v1/instance/'
                   'service-accounts/default/token')
   _ACQUIRE_HEADERS = {"Metadata-Flavor": "Google"}
 
@@ skipping 439 matching lines @@
         username = review.get('email', jmsg.get('name', ''))
         raise GerritError(200, 'Unable to set %s label for user "%s"'
                        ' on change %s.' % (label, username, change))
   jmsg = GetChangeCurrentRevision(host, change)
   if not jmsg:
     raise GerritError(
         200, 'Could not get review information for change "%s"' % change)
   elif jmsg[0]['current_revision'] != revision:
     raise GerritError(200, 'While resetting labels on change "%s", '
                    'a new patchset was uploaded.' % change)