Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1569)

Issue 1882563003: Remove unnecessary CanvasAsyncBlobCreator keep alive protection. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary CanvasAsyncBlobCreator keep alive protection. Closures keep their GCed arguments and |this| alive until completed, hence manual keep-alive handling on top of that isn't required for CanvasAsyncBlobCreator. R=haraken BUG= Committed: https://crrev.com/e0a85c1a76e808e0c0d0452600550f934ff46fc1 Cr-Commit-Position: refs/heads/master@{#387260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -42 lines) Patch
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h View 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 7 chunks +6 lines, -36 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
sof
please take a look. Following up on https://codereview.chromium.org/1878463002/diff/60001/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp#newcode64
4 years, 8 months ago (2016-04-12 14:28:47 UTC) #2
Justin Novosad
+xlai PTAL IIRC, the self reference was necessary in the pre-oilpan world.
4 years, 8 months ago (2016-04-12 15:21:39 UTC) #5
haraken
LGTM
4 years, 8 months ago (2016-04-12 15:54:06 UTC) #6
sof
Sending this one along now; will follow up on any later feedback from canvas owners, ...
4 years, 8 months ago (2016-04-14 05:22:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882563003/1
4 years, 8 months ago (2016-04-14 05:22:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 08:21:28 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e0a85c1a76e808e0c0d0452600550f934ff46fc1 Cr-Commit-Position: refs/heads/master@{#387260}
4 years, 8 months ago (2016-04-14 08:22:35 UTC) #14
Justin Novosad
4 years, 8 months ago (2016-04-18 19:36:00 UTC) #15
Message was sent while issue was closed.
On 2016/04/14 05:22:32, sof wrote:
> Sending this one along now; will follow up on any later feedback from canvas
> owners, of course.

I was OOO part of last week. Catching-up now. post-commit lgtm

Powered by Google App Engine
This is Rietveld 408576698