Enable NV_path_rendering in the Null GL.

Enable NV_path_rendering in the Null GL.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1882563002

Committed: https://skia.googlesource.com/skia/+/b988ecf639f1394ea5e821ac15b989e25e064534

[Sami Väisänen, 2016-04-12 07:40:33]

Description was changed from

==========
Enable NV_path_rendering in the Null GL.

BUG=skia:
==========

to

==========
Enable NV_path_rendering in the Null GL.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Sami Väisänen, 2016-04-12 07:43:34]

Description was changed from

==========
Enable NV_path_rendering in the Null GL.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Enable NV_path_rendering in the Null GL.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Sami Väisänen, 2016-04-12 07:43:34]

svaisanen@nvidia.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2016-04-12 13:53:26]

Can we make this optional? I think for most of our internal uses we would not
want NVPR enabled. It'd be ok to pass a flag to the factory function and for
tools to have multiple null config options.

[Sami Väisänen, 2016-04-13 07:34:37]

On 2016/04/12 13:53:26, bsalomon wrote:
> Can we make this optional? I think for most of our internal uses we would not
> want NVPR enabled. It'd be ok to pass a flag to the factory function and for
> tools to have multiple null config options.

Sure.

[Sami Väisänen, 2016-04-18 08:53:14]

On 2016/04/13 07:34:37, Sami Väisänen wrote:
> On 2016/04/12 13:53:26, bsalomon wrote:
> > Can we make this optional? I think for most of our internal uses we would
not
> > want NVPR enabled. It'd be ok to pass a flag to the factory function and for
> > tools to have multiple null config options.
> 
> Sure.

I'm guessing by internal tools you meant Chromium (based on the comment in
GrGLInterface.h)? Skia's tool GrContextFactory already removes the NVPR
interface from GlInterfaces when NVPR flag is not on. Anyway I added the flag in
GrGLInterface and defaulted it to false as not to break any Chromium code. 

PTAL

[bsalomon, 2016-04-19 14:06:40]

Ah, good point that we already strip NVPR in GrContextFactory. I hadn't thought
about that. However, Chromium does use the null interface directly so we should
probably still make it opt-in. LGTM.

[Sami Väisänen, 2016-04-20 06:41:49]

The CQ bit was checked by svaisanen@nvidia.com

[commit-bot: I haz the power, 2016-04-20 06:41:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882563002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882563002/20001

[commit-bot: I haz the power, 2016-04-20 06:43:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 06:43:08]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[Sami Väisänen, 2016-04-20 07:27:12]

The CQ bit was checked by svaisanen@nvidia.com

[Sami Väisänen, 2016-04-20 07:27:12]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1882563002/#ps40001
(title: "Rebased to resolve merge conflict")

[commit-bot: I haz the power, 2016-04-20 07:27:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882563002/40001

[commit-bot: I haz the power, 2016-04-20 07:36:58]

Description was changed from

==========
Enable NV_path_rendering in the Null GL.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Enable NV_path_rendering in the Null GL.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b988ecf639f1394ea5e821ac15b989e25e064534
==========

[commit-bot: I haz the power, 2016-04-20 07:36:58]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b988ecf639f1394ea5e821ac15b989e25e064534