Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 1882553003: S390: [generators] Store the resume mode in the generator object. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [generators] Store the resume mode in the generator object. port 2e3296666b04f0a038d9239a92e2ff39b5716f74 Original Commit Message: ... instead of doing stack magic. This is a cleanup in preparation for the new generators implementation. R=bmeurer@chromium.org, neis@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/b8f9e955bd675c9809bcb0bb5e768ef600435f87 Cr-Commit-Position: refs/heads/master@{#35417}

Patch Set 1 #

Total comments: 1

Patch Set 2 : correct a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M src/full-codegen/s390/full-codegen-s390.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/s390/builtins-s390.cc View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-12 13:38:50 UTC) #1
JoranSiu
https://codereview.chromium.org/1882553003/diff/1/src/full-codegen/s390/full-codegen-s390.cc File src/full-codegen/s390/full-codegen-s390.cc (right): https://codereview.chromium.org/1882553003/diff/1/src/full-codegen/s390/full-codegen-s390.cc#newcode1761 src/full-codegen/s390/full-codegen-s390.cc:1761: // When we arrive here, r0 holds the generator ...
4 years, 8 months ago (2016-04-12 13:43:56 UTC) #2
JoranSiu
lgtm
4 years, 8 months ago (2016-04-12 13:47:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882553003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882553003/20001
4 years, 8 months ago (2016-04-12 13:48:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 14:06:41 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 14:08:47 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b8f9e955bd675c9809bcb0bb5e768ef600435f87
Cr-Commit-Position: refs/heads/master@{#35417}

Powered by Google App Engine
This is Rietveld 408576698