Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1882533002: Don't force a full decoder reset on seek in VTVDA. (Closed)

Created:
4 years, 8 months ago by sandersd (OOO until July 31)
Modified:
4 years, 8 months ago
Reviewers:
ananta
CC:
chromium-reviews, posciak+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't force a full decoder reset on seek in VTVDA. Instead, set a flag (|waiting_for_idr_|), and wait for the next IDR before using the current configuration again (including for POC computation). This allows us to re-use the same decoder if the config has not actually changed. BUG=601892 Committed: https://crrev.com/dc5535cdd973f0bc70f258afb52bde49b3e37ab5 Cr-Commit-Position: refs/heads/master@{#386803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M content/common/gpu/media/vt_video_decode_accelerator_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator_mac.cc View 4 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sandersd (OOO until July 31)
4 years, 8 months ago (2016-04-12 01:48:25 UTC) #2
ananta
lgtm
4 years, 8 months ago (2016-04-12 19:40:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882533002/1
4 years, 8 months ago (2016-04-12 20:16:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 21:03:37 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 21:05:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc5535cdd973f0bc70f258afb52bde49b3e37ab5
Cr-Commit-Position: refs/heads/master@{#386803}

Powered by Google App Engine
This is Rietveld 408576698