Issue 188253002: Revert of [AudioPlayer] Add test for opening another file from Files.app

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 188253002: Revert of [AudioPlayer] Add test for opening another file from Files.app (Closed)

Created:
6 years, 9 months ago by pkotwicz

Modified:
6 years, 9 months ago

Reviewers:
yoshiki, hirono

CC:
chromium-reviews, extensions-reviews_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of [AudioPlayer] Add test for opening another file from Files.app (https://codereview.chromium.org/177443006/) Reason for revert: This CL seems to be making OpenSpecialTypes/FileManagerBrowserTest.Test/5 timeout. See: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%2BLSan%20Tests%20(2) http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%2BLSan%20Tests%20%282%29/builds/55/steps/browser_tests/logs/Test_5 Original issue's description: > [AudioPlayer] Add test for opening another file from Files.app > > BUG=none > TEST=manually > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255003 TBR=hirono@chromium.org,yoshiki@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255205

Patch Set 1 #

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -86 lines)			Patch
M	chrome/browser/resources/file_manager/background/js/test_util.js	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/file_manager_browsertest/background.js	View	2 chunks	+2 lines, -36 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/file_manager_browsertest/open_special_types.js	View	1 chunk	+3 lines, -35 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pkotwicz

Created Revert of [AudioPlayer] Add test for opening another file from Files.app

6 years, 9 months ago (2014-03-06 01:16:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/188253002/1

6 years, 9 months ago (2014-03-06 01:22:05 UTC) #2

Message was sent while issue was closed.

Change committed as 255205

Expand Messages | Collapse Messages