gpu/command_buffer/client/gles2_implementation.h - Issue 1882503002: Remove setErrorMessageCallback from WebGraphicsContext3D.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/gles2_implementation.h

Issue 1882503002: Remove setErrorMessageCallback from WebGraphicsContext3D. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@errorcallback

Patch Set: weberrors: owned Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/client/context_support.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/client/gles2_implementation.h

diff --git a/gpu/command_buffer/client/gles2_implementation.h b/gpu/command_buffer/client/gles2_implementation.h

index 5e73c4da6c7ab1afdc1c43c6b99e306b5592095b..41ec69353da66b6085b2f158e38cf3fddb0f0410 100644

--- a/gpu/command_buffer/client/gles2_implementation.h

+++ b/gpu/command_buffer/client/gles2_implementation.h

@@ -208,9 +208,11 @@ class GLES2_IMPL_EXPORT GLES2Implementation

const gfx::Rect& display_bounds,

const gfx::RectF& uv_rect) override;

uint64_t ShareGroupTracingGUID() const override;

void SetErrorMessageCallback(

- const base::Callback<void(const char*, int32_t)>& callback);

+ const base::Callback<void(const char*, int32_t)>& callback) override;

+ // TODO(danakj): Move to ContextSupport once ContextProvider doesn't need to

+ // intercept it.

void SetLostContextCallback(const base::Closure& callback);

void GetProgramInfoCHROMIUMHelper(GLuint program,

« no previous file with comments | « gpu/command_buffer/client/context_support.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h » ('j') | no next file with comments »