Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

Issue 1882503002: Remove setErrorMessageCallback from WebGraphicsContext3D. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@errorcallback
Patch Set: weberrors: owned Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc
diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc
index 4496805025fd580c6cf227b38687af57cca8c07f..5877e9844349df31b5c3fc1b2747aa87d72bd191 100644
--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc
+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc
@@ -119,11 +119,8 @@ WebGraphicsContext3DCommandBufferImpl::WebGraphicsContext3DCommandBufferImpl(
WebGraphicsContext3DCommandBufferImpl::
~WebGraphicsContext3DCommandBufferImpl() {
- if (real_gl_) {
- real_gl_->SetErrorMessageCallback(
- base::Callback<void(const char*, int32_t)>());
+ if (real_gl_)
real_gl_->SetLostContextCallback(base::Closure());
- }
Destroy();
}
@@ -149,10 +146,6 @@ bool WebGraphicsContext3DCommandBufferImpl::MaybeInitializeGL() {
return false;
}
- real_gl_->SetErrorMessageCallback(
- base::Bind(&WebGraphicsContext3DCommandBufferImpl::OnErrorMessage,
- // The callback is unset in the destructor.
- base::Unretained(this)));
real_gl_->SetLostContextCallback(
base::Bind(&WebGraphicsContext3DCommandBufferImpl::OnContextLost,
// The callback is unset in the destructor.
@@ -364,12 +357,4 @@ void WebGraphicsContext3DCommandBufferImpl::OnContextLost() {
UmaRecordContextLost(context_type_, state.error, state.context_lost_reason);
}
-void WebGraphicsContext3DCommandBufferImpl::OnErrorMessage(const char* message,
- int id) {
- if (error_message_callback_) {
- blink::WebString str = blink::WebString::fromUTF8(message);
- error_message_callback_->onErrorMessage(str, id);
- }
-}
-
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698