Remove setErrorMessageCallback from WebGraphicsContext3D.

Remove setErrorMessageCallback from WebGraphicsContext3D.

This adds a SetErrorMessageCallback on ContextSupport and we use that
from blink now.

We move the method on WebGraphicsContext3D to
WebGraphicsContext3DProvider, which takes a WebCallback instead
of using adaptor classes/pointers. This callback is passed through
the ContextProvider directly to the ContextSupport (aka the
GLES2Implementation).

This was the last thing used on WebGraphicsContext3D in blink so we
can delete it next, from blink's perspective at least.

R=kbr@chromium.org, esprehn@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/83b35d4f80982666fbccf74651d881130802cb8a
Cr-Commit-Position: refs/heads/master@{#386846}

[danakj, 2016-04-12 00:38:15]

Description was changed from

==========
Remove setErrorMessageCallback from WebGraphicsContext3D.

This adds a SetErrorMessageCallback on ContextSupport and we use that
from blink now.

We move the method on WebGraphicsContext3D to
WebGraphicsContext3DProvider, which takes a WebCallback instead
of using adaptor classes/pointers. This callback is passed through
the ContextProvider directly to the ContextSupport (aka the
GLES2Implementation).

This was the last thing used on WebGraphicsContext3D in blink so we
can delete it next, from blink's perspective at least.

R=kbr@chromium.org, pdr@chromium.org, piman@chromium.org
BUG=584497
==========

to

==========
Remove setErrorMessageCallback from WebGraphicsContext3D.

This adds a SetErrorMessageCallback on ContextSupport and we use that
from blink now.

We move the method on WebGraphicsContext3D to
WebGraphicsContext3DProvider, which takes a WebCallback instead
of using adaptor classes/pointers. This callback is passed through
the ContextProvider directly to the ContextSupport (aka the
GLES2Implementation).

This was the last thing used on WebGraphicsContext3D in blink so we
can delete it next, from blink's perspective at least.

R=kbr@chromium.org, pdr@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-04-12 00:38:16]

Description was changed from

==========
Remove setErrorMessageCallback from WebGraphicsContext3D.

This adds a SetErrorMessageCallback on ContextSupport and we use that
from blink now.

We move the method on WebGraphicsContext3D to
WebGraphicsContext3DProvider, which takes a WebCallback instead
of using adaptor classes/pointers. This callback is passed through
the ContextProvider directly to the ContextSupport (aka the
GLES2Implementation).

This was the last thing used on WebGraphicsContext3D in blink so we
can delete it next, from blink's perspective at least.

R=kbr@chromium.org, pdr@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove setErrorMessageCallback from WebGraphicsContext3D.

This adds a SetErrorMessageCallback on ContextSupport and we use that
from blink now.

We move the method on WebGraphicsContext3D to
WebGraphicsContext3DProvider, which takes a WebCallback instead
of using adaptor classes/pointers. This callback is passed through
the ContextProvider directly to the ContextSupport (aka the
GLES2Implementation).

This was the last thing used on WebGraphicsContext3D in blink so we
can delete it next, from blink's perspective at least.

R=kbr@chromium.org, pdr@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[danakj, 2016-04-12 00:38:16]

Description was changed from

==========
Remove setErrorMessageCallback from WebGraphicsContext3D.

This adds a SetErrorMessageCallback on ContextSupport and we use that
from blink now.

We move the method on WebGraphicsContext3D to
WebGraphicsContext3DProvider, which takes a WebCallback instead
of using adaptor classes/pointers. This callback is passed through
the ContextProvider directly to the ContextSupport (aka the
GLES2Implementation).

This was the last thing used on WebGraphicsContext3D in blink so we
can delete it next, from blink's perspective at least.

R=kbr@chromium.org, pdr@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove setErrorMessageCallback from WebGraphicsContext3D.

This adds a SetErrorMessageCallback on ContextSupport and we use that
from blink now.

We move the method on WebGraphicsContext3D to
WebGraphicsContext3DProvider, which takes a WebCallback instead
of using adaptor classes/pointers. This callback is passed through
the ContextProvider directly to the ContextSupport (aka the
GLES2Implementation).

This was the last thing used on WebGraphicsContext3D in blink so we
can delete it next, from blink's perspective at least.

R=kbr@chromium.org, pdr@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-04-12 00:38:34]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 00:39:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882503002/1

[danakj, 2016-04-12 00:39:57]

Description was changed from

==========
Remove setErrorMessageCallback from WebGraphicsContext3D.

This adds a SetErrorMessageCallback on ContextSupport and we use that
from blink now.

We move the method on WebGraphicsContext3D to
WebGraphicsContext3DProvider, which takes a WebCallback instead
of using adaptor classes/pointers. This callback is passed through
the ContextProvider directly to the ContextSupport (aka the
GLES2Implementation).

This was the last thing used on WebGraphicsContext3D in blink so we
can delete it next, from blink's perspective at least.

R=kbr@chromium.org, pdr@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remove setErrorMessageCallback from WebGraphicsContext3D.

This adds a SetErrorMessageCallback on ContextSupport and we use that
from blink now.

We move the method on WebGraphicsContext3D to
WebGraphicsContext3DProvider, which takes a WebCallback instead
of using adaptor classes/pointers. This callback is passed through
the ContextProvider directly to the ContextSupport (aka the
GLES2Implementation).

This was the last thing used on WebGraphicsContext3D in blink so we
can delete it next, from blink's perspective at least.

R=kbr@chromium.org, esprehn@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-04-12 00:40:00]

danakj@chromium.org changed reviewers:
+ esprehn@chromium.org
- pdr@chromium.org

[danakj, 2016-04-12 00:40:01]

piman: cc/ content/ gpu/
kbr: webgl/
esprehn: public/ (I renamed WebClosure to WebCallback and generalized it. Kept a
WebClosure alias tho.)

[danakj, 2016-04-12 00:41:32]

danakj@chromium.org changed reviewers:
+ bajones@chromium.org, zmo@google.com

[danakj, 2016-04-12 00:41:33]

oh, kbr is away.

+zmo and bajones, can one of you please have a look at the webgl/ and
platform/graphics/ things?

[commit-bot: I haz the power, 2016-04-12 00:42:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 00:42:35]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[danakj, 2016-04-12 00:44:50]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 00:45:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882503002/20001

[esprehn, 2016-04-12 00:45:43]

This is kind of confusing since we have WebCallbacks (note the "s" at the end)
which is something totally different...

[danakj, 2016-04-12 00:46:37]

On Mon, Apr 11, 2016 at 5:45 PM, <esprehn@chromium.org> wrote:

> This is kind of confusing since we have WebCallbacks (note the "s" at the
> end)
> which is something totally different...
>

I know.. :/ What would you like me to do?

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[danakj, 2016-04-12 00:51:49]

On Mon, Apr 11, 2016 at 5:45 PM, <esprehn@chromium.org> wrote:

> This is kind of confusing since we have WebCallbacks (note the "s" at the
> end)
> which is something totally different...
>

I know.. :/ What would you like me to do?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2016-04-12 00:58:00]

On 2016/04/12 00:45:43, esprehn wrote:
> This is kind of confusing since we have WebCallbacks (note the "s" at the end)
> which is something totally different...

Renamed to WebFunction (left WebClosure as is, kinda matches WTF::Function and
SameThreadClosure?). PTAL

[danakj, 2016-04-12 00:58:46]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 00:59:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882503002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882503002/40001

[danakj, 2016-04-12 01:00:18]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 01:00:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882503002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882503002/60001

[piman, 2016-04-12 01:45:13]

lgtm

[esprehn, 2016-04-12 01:59:56]

lgtm

[commit-bot: I haz the power, 2016-04-12 02:30:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 02:30:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bajones, 2016-04-12 03:57:27]

webgl/ lgtm

[danakj, 2016-04-12 18:22:25]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-04-12 18:22:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 18:22:52]

This CL has an open dependency (Issue 1864723003 Patch 360001). Please resolve
the dependency and try again.

[danakj, 2016-04-12 18:56:49]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 18:57:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882503002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882503002/60001

[commit-bot: I haz the power, 2016-04-12 19:02:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 19:02:39]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-04-12 19:54:03]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-12 19:54:09]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-04-12 20:02:52]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-12 20:02:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, bajones@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1882503002/#ps80001
(title: "weberrors: rebase")

[commit-bot: I haz the power, 2016-04-12 20:03:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882503002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882503002/80001

[commit-bot: I haz the power, 2016-04-12 21:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 21:27:44]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[danakj, 2016-04-12 21:41:20]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-12 21:41:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, bajones@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1882503002/#ps100001
(title: "weberrors: owned")

[danakj, 2016-04-12 21:42:16]

https://codereview.chromium.org/1882503002/diff/80001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/functional/WebFunction.h (right):

https://codereview.chromium.org/1882503002/diff/80001/third_party/WebKit/publ...
third_party/WebKit/public/platform/functional/WebFunction.h:46: m_callback =
base::Bind(&RunAndDelete<R, Args...>,
base::Passed(base::WrapUnique(c.leakPtr())));
A problem came up in the webgl tests. Using Passed here means the WTF::Function
is destroyed when m_callback is Run(). But we may call the callback more than
once, causing a crash.

Instead, I made base::Callback own the WTF::Function, so they share a lifetime,
and Run() can be used more than once.

[commit-bot: I haz the power, 2016-04-12 21:42:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882503002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882503002/100001

[commit-bot: I haz the power, 2016-04-12 23:14:24]

Description was changed from

==========
Remove setErrorMessageCallback from WebGraphicsContext3D.

This adds a SetErrorMessageCallback on ContextSupport and we use that
from blink now.

We move the method on WebGraphicsContext3D to
WebGraphicsContext3DProvider, which takes a WebCallback instead
of using adaptor classes/pointers. This callback is passed through
the ContextProvider directly to the ContextSupport (aka the
GLES2Implementation).

This was the last thing used on WebGraphicsContext3D in blink so we
can delete it next, from blink's perspective at least.

R=kbr@chromium.org, esprehn@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remove setErrorMessageCallback from WebGraphicsContext3D.

This adds a SetErrorMessageCallback on ContextSupport and we use that
from blink now.

We move the method on WebGraphicsContext3D to
WebGraphicsContext3DProvider, which takes a WebCallback instead
of using adaptor classes/pointers. This callback is passed through
the ContextProvider directly to the ContextSupport (aka the
GLES2Implementation).

This was the last thing used on WebGraphicsContext3D in blink so we
can delete it next, from blink's perspective at least.

R=kbr@chromium.org, esprehn@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-04-12 23:14:26]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-12 23:17:39]

Description was changed from

==========
Remove setErrorMessageCallback from WebGraphicsContext3D.

This adds a SetErrorMessageCallback on ContextSupport and we use that
from blink now.

We move the method on WebGraphicsContext3D to
WebGraphicsContext3DProvider, which takes a WebCallback instead
of using adaptor classes/pointers. This callback is passed through
the ContextProvider directly to the ContextSupport (aka the
GLES2Implementation).

This was the last thing used on WebGraphicsContext3D in blink so we
can delete it next, from blink's perspective at least.

R=kbr@chromium.org, esprehn@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remove setErrorMessageCallback from WebGraphicsContext3D.

This adds a SetErrorMessageCallback on ContextSupport and we use that
from blink now.

We move the method on WebGraphicsContext3D to
WebGraphicsContext3DProvider, which takes a WebCallback instead
of using adaptor classes/pointers. This callback is passed through
the ContextProvider directly to the ContextSupport (aka the
GLES2Implementation).

This was the last thing used on WebGraphicsContext3D in blink so we
can delete it next, from blink's perspective at least.

R=kbr@chromium.org, esprehn@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/83b35d4f80982666fbccf74651d881130802cb8a
Cr-Commit-Position: refs/heads/master@{#386846}
==========

[commit-bot: I haz the power, 2016-04-12 23:17:41]

Patchset 6 (id:??) landed as
https://crrev.com/83b35d4f80982666fbccf74651d881130802cb8a
Cr-Commit-Position: refs/heads/master@{#386846}

[Ken Russell (switch to Gerrit), 2016-04-14 04:33:57]

Very nice and sorry for the late reply. LGTM after the fact.