Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5260)

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

Issue 1882483002: MD Settings: OnStartup, implementing "Edit" functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@edit_on_startup_move_delete
Patch Set: Nit. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
diff --git a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
index a3d0fabd227323c50cca2273910b8f47cc47d6b4..6941c08dfaa161bb741f49a923ca4b88baa34ed2 100644
--- a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
+++ b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
@@ -22,7 +22,11 @@ Polymer({
*/
startupPages_: Array,
+ /** @private */
showStartupUrlDialog_: Boolean,
+
+ /** @private {?StartupPageInfo} */
+ startupUrlDialogModel_: Object,
},
/** @override */
@@ -32,6 +36,17 @@ Polymer({
this.startupPages_ = startupPages;
}.bind(this));
this.browserProxy_.loadStartupPages();
+
+ this.addEventListener(settings.EDIT_STARTUP_URL_EVENT, function(event) {
+ this.startupUrlDialogModel_ = event.detail;
+ this.openDialog_();
+ event.stopPropagation();
+ }.bind(this));
+ },
+
+ /** @private */
+ onAddPageTap_: function() {
+ this.openDialog_();
},
/**
@@ -40,12 +55,13 @@ Polymer({
* (because of 'restamp').
* @private
*/
- onAddPageTap_: function() {
+ openDialog_: function() {
this.showStartupUrlDialog_ = true;
this.async(function() {
var dialog = this.$$('settings-startup-url-dialog');
dialog.addEventListener('iron-overlay-closed', function() {
this.showStartupUrlDialog_ = false;
+ this.startupUrlDialogModel_ = null;
}.bind(this));
}.bind(this));
},

Powered by Google App Engine
This is Rietveld 408576698