MD Settings: OnStartup, implementing "Edit" functionality.

chrome/browser/resources/settings/on_startup_page/startup_url_entry.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview settings-startup-url-entry represents a UI component that
  * displayes a URL that is loaded during startup. It includes a menu that allows
  * the user to edit/remove the entry.
  */
+
+cr.define('settings', function() {
+  /**
+   * The name of the event fired from this element when the "Edit" option is
+   * tapped.
+   * @type {string}
+   */
+  var EditStartupUrlEvent = 'edit-startup-url';
+
+  return {
+    EditStartupUrlEvent: EditStartupUrlEvent,
+  };
+});

[dschuyler, 2016/04/14 00:49:38]

Can the above be simplified?

[dpapad, 2016/04/14 01:13:39]

First, I added a compile target for this to ensure it compiles (see
compiled_resources2.gyp change). Then I tried to simplify it, by inlining the
string and removing the "var EditStartupUrlEvent", but compiler did not
understand that syntax.

[Dan Beam, 2016/04/14 01:32:30]

cr.exportPath('settings');

/** @type {string} */
setings.EditStartupUrlEvent = 'edit-startup-url';

but shouldn't this be in like FINAL_CASE?

[dpapad, 2016/04/14 01:50:53]

Done the simplification. Also changed to @const and FINAL_CASE

+
 Polymer({
   is: 'settings-startup-url-entry',
 
   properties: {
     /** @type {!StartupPageInfo} */
     model: Object,
   },
 
   /**
    * @param {string} url Location of an image to get a set of icons fors.
    * @return {string} A set of icon URLs.
    * @private
    */
   getIconSet_: function(url) {
     return getFaviconImageSet(url);
   },
 
   /** @private */
   onRemoveTap_: function() {
+    this.$$('iron-dropdown').close();
     settings.StartupUrlsPageBrowserProxyImpl.getInstance().removeStartupPage(
         this.model.modelIndex);
   },
+
+  /** @private */
+  onEditTap_: function() {
+    this.$$('iron-dropdown').close();
+    this.fire(settings.EditStartupUrlEvent, this.model);
+  },
 });