Fix ports to pass generic options which work with new and old drivers

Fix ports to pass generic options which work with new and old drivers

- Don't prefix the ar operation with dash
- GNU's ar allows optionally prefixing the operation with a dash, but this is not
supported by the current version of LLVM's ar which we use with the new
toolchain driver. To ensure that we can build all packages with both drivers,
we'll always use the non-prefixed operation.
- Pass CFLAGS and CXXFLAGS to speex which are set in NACLPORTS_CFLAGS and NACLPORTS_CXXFLAGS

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
R=bradnelson@google.com, phosek@chromium.org

Committed: https://chromium.googlesource.com/webports/+/d938dd2917ec91399798e8ed64c9161f54237487

[Ankur Mittal, 2016-04-11 22:01:35]

Description was changed from

==========
Fix ports to support generic options which work with new and old drivers

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

to

==========
Fix ports to support generic options which work with new and old drivers

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

[Ankur Mittal, 2016-04-11 22:01:35]

anmittal@chromium.org changed reviewers:
+ bradnelson@chromium.org, phosek@chromium.org

[Ankur Mittal, 2016-04-11 22:01:56]

PTAL

[Ankur Mittal, 2016-04-11 22:02:18]

Description was changed from

==========
Fix ports to support generic options which work with new and old drivers

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

to

==========
Fix ports to pass generic options which work with new and old drivers

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

[Petr Hosek, 2016-04-11 22:33:25]

Could you make the commit message more descriptive? Something like:

Don't prefix the ar operation with dash

GNU's ar allows optionally prefixing the operation with a dash, but this is not
supported by the current version of LLVM's ar which we use with the new
toolchain driver. To ensure that we can build all packages with both drivers,
we'll always use the non-prefixed operation.

[Ankur Mittal, 2016-04-11 22:35:41]

Description was changed from

==========
Fix ports to pass generic options which work with new and old drivers

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

to

==========
Fix ports to pass generic options which work with new and old drivers
- Don't prefix the ar operation with dash
- GNU's ar allows optionally prefixing the operation with a dash, but this is
not
supported by the current version of LLVM's ar which we use with the new
toolchain driver. To ensure that we can build all packages with both drivers,
we'll always use the non-prefixed operation.
- Pass CFLAGS and CXXFLAGS to speex which are set in NACL_CFLAGS and
NACL_CXXFLAGS

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

[Ankur Mittal, 2016-04-11 22:36:12]

Description was changed from

==========
Fix ports to pass generic options which work with new and old drivers
- Don't prefix the ar operation with dash
- GNU's ar allows optionally prefixing the operation with a dash, but this is
not
supported by the current version of LLVM's ar which we use with the new
toolchain driver. To ensure that we can build all packages with both drivers,
we'll always use the non-prefixed operation.
- Pass CFLAGS and CXXFLAGS to speex which are set in NACL_CFLAGS and
NACL_CXXFLAGS

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

to

==========
Fix ports to pass generic options which work with new and old drivers
- Don't prefix the ar operation with dash
- GNU's ar allows optionally prefixing the operation with a dash, but this is
not
supported by the current version of LLVM's ar which we use with the new
toolchain driver. To ensure that we can build all packages with both drivers,
we'll always use the non-prefixed operation.
- Pass CFLAGS and CXXFLAGS to speex which are set in NACLPORTS_CFLAGS and
NACLPORTS_CXXFLAGS

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

[Ankur Mittal, 2016-04-11 23:08:33]

On 2016/04/11 22:33:25, Petr Hosek wrote:
> Could you make the commit message more descriptive? Something like:
> 
> Don't prefix the ar operation with dash
> 
> GNU's ar allows optionally prefixing the operation with a dash, but this is
not
> supported by the current version of LLVM's ar which we use with the new
> toolchain driver. To ensure that we can build all packages with both drivers,
> we'll always use the non-prefixed operation.

done

[Petr Hosek, 2016-04-12 18:14:17]

lgtm, can you please add an empty line between the subject (the first line) and
the description?

[Ankur Mittal, 2016-04-12 18:15:27]

Description was changed from

==========
Fix ports to pass generic options which work with new and old drivers
- Don't prefix the ar operation with dash
- GNU's ar allows optionally prefixing the operation with a dash, but this is
not
supported by the current version of LLVM's ar which we use with the new
toolchain driver. To ensure that we can build all packages with both drivers,
we'll always use the non-prefixed operation.
- Pass CFLAGS and CXXFLAGS to speex which are set in NACLPORTS_CFLAGS and
NACLPORTS_CXXFLAGS

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

to

==========
Fix ports to pass generic options which work with new and old drivers

- Don't prefix the ar operation with dash
- GNU's ar allows optionally prefixing the operation with a dash, but this is
not
supported by the current version of LLVM's ar which we use with the new
toolchain driver. To ensure that we can build all packages with both drivers,
we'll always use the non-prefixed operation.
- Pass CFLAGS and CXXFLAGS to speex which are set in NACLPORTS_CFLAGS and
NACLPORTS_CXXFLAGS

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

[bradn, 2016-04-12 20:30:15]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-04-12 20:30:16]

lgtm

https://codereview.chromium.org/1882443002/diff/1/ports/speex/build.sh
File ports/speex/build.sh (right):

https://codereview.chromium.org/1882443002/diff/1/ports/speex/build.sh#newcode1
ports/speex/build.sh:1: # Copyright (c) 2011 The Native Client Authors. All
rights reserved.
2016

[Ankur Mittal, 2016-04-12 21:26:12]

https://codereview.chromium.org/1882443002/diff/1/ports/speex/build.sh
File ports/speex/build.sh (right):

https://codereview.chromium.org/1882443002/diff/1/ports/speex/build.sh#newcode1
ports/speex/build.sh:1: # Copyright (c) 2011 The Native Client Authors. All
rights reserved.
On 2016/04/12 20:30:16, bradn wrote:
> 2016

Done.

[Ankur Mittal, 2016-04-12 21:27:04]

The CQ bit was checked by anmittal@chromium.org

[Ankur Mittal, 2016-04-12 21:27:05]

The patchset sent to the CQ was uploaded after l-g-t-m from phosek@chromium.org,
bradnelson@google.com
Link to the patchset: https://codereview.chromium.org/1882443002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-04-12 21:27:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882443002/20001

[commit-bot: I haz the power, 2016-04-12 21:27:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 21:27:12]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Ankur Mittal, 2016-04-12 21:28:24]

Description was changed from

==========
Fix ports to pass generic options which work with new and old drivers

- Don't prefix the ar operation with dash
- GNU's ar allows optionally prefixing the operation with a dash, but this is
not
supported by the current version of LLVM's ar which we use with the new
toolchain driver. To ensure that we can build all packages with both drivers,
we'll always use the non-prefixed operation.
- Pass CFLAGS and CXXFLAGS to speex which are set in NACLPORTS_CFLAGS and
NACLPORTS_CXXFLAGS

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

to

==========
Fix ports to pass generic options which work with new and old drivers

- Don't prefix the ar operation with dash
- GNU's ar allows optionally prefixing the operation with a dash, but this is
not
supported by the current version of LLVM's ar which we use with the new
toolchain driver. To ensure that we can build all packages with both drivers,
we'll always use the non-prefixed operation.
- Pass CFLAGS and CXXFLAGS to speex which are set in NACLPORTS_CFLAGS and
NACLPORTS_CXXFLAGS

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
R=bradnelson@google.com, phosek@chromium.org

Committed:
https://chromium.googlesource.com/webports/+/d938dd2917ec91399798e8ed64c9161f...
==========

[Ankur Mittal, 2016-04-12 21:28:25]

Committed patchset #2 (id:20001) manually as
d938dd2917ec91399798e8ed64c9161f54237487 (presubmit successful).