Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: ios/third_party/earl_grey/BUILD.gn

Issue 1882423002: [iOS/OSX/GN] Add -install_name to the shared_library ldflags on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-earlgrey
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/third_party/earl_grey/BUILD.gn
diff --git a/ios/third_party/earl_grey/BUILD.gn b/ios/third_party/earl_grey/BUILD.gn
index bf9c18c3563800c8e8a634b3b7aad1be587bae8e..421ed8acec7d2901aeb1942ada11d2f063000dd6 100644
--- a/ios/third_party/earl_grey/BUILD.gn
+++ b/ios/third_party/earl_grey/BUILD.gn
@@ -16,9 +16,7 @@ config("config") {
ldflags = common_flags
}
-ios_framework_bundle("earl_grey") {
- output_name = "EarlGrey"
-
+ios_framework_bundle("EarlGrey") {
testonly = true
sources = [
"src/EarlGrey/Action/GREYAction.h",
@@ -238,7 +236,7 @@ ios_framework_bundle("earl_grey") {
"//third_party/google_toolbox_for_mac",
]
public_deps = [
- "//ios/third_party/ochamcrest",
+ "//ios/third_party/ochamcrest:OCHamcrest",
]
libs = [

Powered by Google App Engine
This is Rietveld 408576698