Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1983)

Unified Diff: build/config/mac/rules.gni

Issue 1882423002: [iOS/OSX/GN] Add -install_name to the shared_library ldflags on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-earlgrey
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | ios/third_party/earl_grey/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/rules.gni
diff --git a/build/config/mac/rules.gni b/build/config/mac/rules.gni
index 2bcfbd68361c450ebb27c24881d0510df66d1cb9..8cad8424cf76be2301d5151fcdeb03652250b296 100644
--- a/build/config/mac/rules.gni
+++ b/build/config/mac/rules.gni
@@ -55,15 +55,17 @@ template("framework_bundle") {
"visibility",
])
output_name = _output_name
- output_prefix_override = true
- output_extension = ""
+ ldflags = [
+ "-install_name",
+ "@rpath/$_framework_name/$_output_name",
Robert Sesek 2016/04/13 15:30:58 This isn't going to be correct in all cases, and d
sdefresne 2016/04/13 16:28:43 OK. This appears to be required for iOS (at least
+ ]
}
bundle_data(_shared_library_bundle_data) {
visibility = [ ":$_framework_target" ]
forward_variables_from(invoker, [ "testonly" ])
sources = [
- "$root_out_dir/${_output_name}",
+ "$root_out_dir/$shlib_prefix$_output_name$shlib_extension",
]
outputs = [
"{{bundle_executable_dir}}/$_output_name",
« no previous file with comments | « BUILD.gn ('k') | ios/third_party/earl_grey/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698