Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1882383002: Fix Javascript bugs in animation LayoutTests (Closed)

Created:
4 years, 8 months ago by alancutter (OOO until 2018)
Modified:
4 years, 8 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_failOnUncaughtError
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Javascript bugs in animation LayoutTests These tests were hitting unintended exceptions in their test code. This patch corrects their errors. BUG=602886 Committed: https://crrev.com/af8ba97cd1a395bb097493d819cef8ea1888d447 Cr-Commit-Position: refs/heads/master@{#386946}

Patch Set 1 #

Patch Set 2 : Rebased #

Messages

Total messages: 12 (6 generated)
alancutter (OOO until 2018)
4 years, 8 months ago (2016-04-13 07:18:15 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882383002/20001
4 years, 8 months ago (2016-04-13 07:18:32 UTC) #5
Eric Willigers
lgtm
4 years, 8 months ago (2016-04-13 07:28:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882383002/20001
4 years, 8 months ago (2016-04-13 07:34:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 09:21:20 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 09:22:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/af8ba97cd1a395bb097493d819cef8ea1888d447
Cr-Commit-Position: refs/heads/master@{#386946}

Powered by Google App Engine
This is Rietveld 408576698