Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1882353002: nacl: Remove unnecessary reference to BrokerAddTargetPeer. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

nacl: Remove unnecessary reference to BrokerAddTargetPeer. BUG=493414 Committed: https://crrev.com/eab4594d16f3c58b6ff44841ffa7370804657470 Cr-Commit-Position: refs/heads/master@{#388256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M components/nacl/browser/nacl_process_host.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882353002/1
4 years, 8 months ago (2016-04-13 00:48:18 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/204074)
4 years, 8 months ago (2016-04-13 02:28:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882353002/1
4 years, 8 months ago (2016-04-15 17:42:34 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 18:46:37 UTC) #8
erikchen
mseaborn: Please review.
4 years, 8 months ago (2016-04-15 20:25:30 UTC) #10
Mark Seaborn
LGTM
4 years, 8 months ago (2016-04-19 17:59:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882353002/1
4 years, 8 months ago (2016-04-19 18:00:44 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 18:43:25 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:13 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eab4594d16f3c58b6ff44841ffa7370804657470
Cr-Commit-Position: refs/heads/master@{#388256}

Powered by Google App Engine
This is Rietveld 408576698