Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1882333002: Simplify Physical Web hook in Chromium startup (Closed)

Created:
4 years, 8 months ago by cco3
Modified:
4 years, 8 months ago
Reviewers:
Yaron, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify Physical Web hook in Chromium startup This will allow us to do more on startup without having to put more lines into both the DeferredStartupHandler and the PhysicalWeb class. Eventually, we may want to record some UMA stats on startup, and this will allow us to do so easily. BUG=594194 Committed: https://crrev.com/dd04070aa5257204200985a97148f7f8de4d508b Cr-Commit-Position: refs/heads/master@{#387785}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -26 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java View 3 chunks +16 lines, -20 lines 2 comments Download

Messages

Total messages: 13 (4 generated)
cco3
4 years, 8 months ago (2016-04-13 00:14:43 UTC) #2
mattreynolds
lgtm
4 years, 8 months ago (2016-04-13 17:27:36 UTC) #3
cco3
This is a safe part of a recently reverted commit. https://codereview.chromium.org/1878063002/
4 years, 8 months ago (2016-04-13 17:28:50 UTC) #5
Yaron
lgtm https://codereview.chromium.org/1882333002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java (right): https://codereview.chromium.org/1882333002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java#newcode110 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java:110: public static void onChromeStart(ChromeApplication application) { I'd love ...
4 years, 8 months ago (2016-04-14 01:35:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882333002/1
4 years, 8 months ago (2016-04-15 22:10:00 UTC) #8
cco3
https://codereview.chromium.org/1882333002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java (right): https://codereview.chromium.org/1882333002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java#newcode110 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java:110: public static void onChromeStart(ChromeApplication application) { On 2016/04/14 01:35:55, ...
4 years, 8 months ago (2016-04-15 22:10:27 UTC) #9
cco3
On 2016/04/15 22:10:27, cco3 wrote: > https://codereview.chromium.org/1882333002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java > File > chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java > (right): > > ...
4 years, 8 months ago (2016-04-15 22:10:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-16 01:48:19 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 01:49:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd04070aa5257204200985a97148f7f8de4d508b
Cr-Commit-Position: refs/heads/master@{#387785}

Powered by Google App Engine
This is Rietveld 408576698