Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1882293005: Specify language for code blocks. (Closed)

Created:
4 years, 8 months ago by cmumford1
Modified:
4 years, 8 months ago
Reviewers:
jam, cmumford
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify language for code blocks. Mark all C++ code blocks to enable syntax coloring on server. Committed: https://crrev.com/f3d3cabe0aac002c29bf4614a602e4cdde713370 Cr-Commit-Position: refs/heads/master@{#387638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M docs/mojo_in_chromium.md View 9 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
cmumford
ptal: The local server (tools/md_browser/md_browser.py) doesn't do syntax coloring, but chromium.googlesource.com does.
4 years, 8 months ago (2016-04-13 17:43:38 UTC) #2
cmumford
4 years, 8 months ago (2016-04-14 22:33:20 UTC) #6
jam
lgtm
4 years, 8 months ago (2016-04-15 15:23:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882293005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882293005/1
4 years, 8 months ago (2016-04-15 17:03:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 17:49:13 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 17:50:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3d3cabe0aac002c29bf4614a602e4cdde713370
Cr-Commit-Position: refs/heads/master@{#387638}

Powered by Google App Engine
This is Rietveld 408576698