Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: scripts/slave/recipe_modules/webrtc/steps.py

Issue 1882293003: 🐎 Remove --shard-timeout from webrtc recipes now that they are in wrapper scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@wrapper-3
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5_.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/webrtc/steps.py
diff --git a/scripts/slave/recipe_modules/webrtc/steps.py b/scripts/slave/recipe_modules/webrtc/steps.py
index d71c134555bebbefcf89f6d891d898e239649476..18284dab4a3fd847d9fdc3b369469517ca328d70 100644
--- a/scripts/slave/recipe_modules/webrtc/steps.py
+++ b/scripts/slave/recipe_modules/webrtc/steps.py
@@ -120,17 +120,9 @@ def get_android_tool(api):
class AndroidTest(Test):
- # WebRTC tests need a longer timeout to avoid getting killed by the Chromium
- # Android test framework.
- _SHARD_TIMEOUT = 15 * 60
-
- def __init__(self, name):
- super(AndroidTest, self).__init__(name)
-
def run(self, api, suffix):
api.m.chromium_android.run_test_suite(self._name,
- tool=get_android_tool(api),
- shard_timeout=self._SHARD_TIMEOUT)
+ tool=get_android_tool(api))
class AndroidInstrumentationTest(Test):
@@ -152,9 +144,6 @@ class AndroidPerfTest(Test):
from the gtest binaries since the way of running perf tests with telemetry
is entirely different.
"""
- # WebRTC tests need a longer timeout to avoid getting killed by the Chromium
- # Android test framework.
- _SHARD_TIMEOUT = 45 * 60
def __init__(self, name, revision, perf_id=None):
super(AndroidPerfTest, self).__init__(name)
@@ -166,17 +155,15 @@ class AndroidPerfTest(Test):
# Run as a normal test for trybots and Debug, without perf data scraping.
api.m.chromium_android.run_test_suite(
self._name,
- tool=get_android_tool(api),
- shard_timeout=self._SHARD_TIMEOUT)
+ tool=get_android_tool(api))
else:
- args = ['gtest', '-s', self._name, '--verbose', '--release',
- '-t', str(self._SHARD_TIMEOUT)]
- tool = get_android_tool(api)
+ wrapper_script = api.m.chromium.output_dir.join('bin',
+ 'run_%s' % self._name)
+ args = ['--verbose']
api.add_test(name=self._name,
- test=api.m.chromium_android.c.test_runner,
+ test=wrapper_script,
args=args,
revision=self._revision,
perf_test=True,
- perf_dashboard_id=self._name,
- env={'CHROMIUM_OUT_DIR': api.m.chromium.output_dir})
+ perf_dashboard_id=self._name)
« no previous file with comments | « no previous file | scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5_.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698