Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1882263002: Turn off summaries in context when building summary from AST. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Turn off summaries in context when building summary from AST. When building summaries from ASTs, we only use the context to read source files; we don't need it to provide an element model. Therefore, we can save some time by turning off the context's use of summaries, because this prevents it from trying to eagerly deserialize the summaries of dart:async and dart:core. Saves a significant amount of time when building a summary of a small package using ASTs. For example, saves ~37% of time when building a strong mode summary of the "yaml" package. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/2a5db6841bf99b96e3a1c14165190b1c8fa67622

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M pkg/analyzer_cli/lib/src/build_mode.dart View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-12 21:15:52 UTC) #2
Brian Wilkerson
lgtm
4 years, 8 months ago (2016-04-12 21:27:05 UTC) #3
Paul Berry
4 years, 8 months ago (2016-04-14 12:59:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2a5db6841bf99b96e3a1c14165190b1c8fa67622 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698