chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc - Issue 1882243004: Convert //chrome/browser/sync from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc

Issue 1882243004: Convert //chrome/browser/sync from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/profile_sync_service_harness.cc ('k') | chrome/browser/sync/test/integration/single_client_extensions_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc b/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc

index ed696cec9bca1cad5216fcec0a629011f49f59b2..3cebd2e2457a1e2a93805f54ba0f9e1cc6354ebb 100644

--- a/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc

+++ b/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc

@@ -352,7 +352,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,

GetFakeServer()->GetSyncEntitiesByModelType(syncer::BOOKMARKS);

ASSERT_EQ(1ul, server_bookmarks.size());

std::string entity_id = server_bookmarks[0].id_string();

- scoped_ptr<fake_server::FakeServerEntity> tombstone(

+ std::unique_ptr<fake_server::FakeServerEntity> tombstone(

fake_server::TombstoneEntity::Create(entity_id));

GetFakeServer()->InjectEntity(std::move(tombstone));