Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1882243004: Convert //chrome/browser/sync from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
pavely
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //chrome/browser/sync from scoped_ptr to std::unique_ptr BUG=554298 R=pavely@chromium.org Committed: https://crrev.com/0569a0ed6347980265b437c61b5849ee2ca2c529 Cr-Commit-Position: refs/heads/master@{#387350}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -172 lines) Patch
M chrome/browser/sync/chrome_sync_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/chrome_sync_client.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/chrome_sync_client_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_android.cc View 6 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_test_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_test_util.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/sync/sessions/notification_service_sessions_router.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 15 chunks +45 lines, -48 lines 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash_unittest.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/sync/sync_global_error_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/sync/sync_startup_tracker_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_ui_util_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/extension_settings_helper.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync/test/integration/preferences_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/profile_sync_service_harness.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_extensions_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_wifi_credentials_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_app_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 5 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_wifi_credentials_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/typed_urls_helper.cc View 5 chunks +15 lines, -20 lines 0 comments Download
M chrome/browser/sync/test/integration/wifi_credentials_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/wifi_credentials_helper.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
This is largely a search and replace. There's probably some IWYU errors (files that don't ...
4 years, 8 months ago (2016-04-13 23:21:37 UTC) #1
pavely
lgtm https://codereview.chromium.org/1882243004/diff/1/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc File chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc (right): https://codereview.chromium.org/1882243004/diff/1/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc#newcode5 chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc:5: #include <memory> I think this file doesn't use ...
4 years, 8 months ago (2016-04-14 06:07:41 UTC) #2
dcheng
https://codereview.chromium.org/1882243004/diff/1/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc File chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc (right): https://codereview.chromium.org/1882243004/diff/1/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc#newcode5 chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc:5: #include <memory> On 2016/04/14 at 06:07:41, pavely wrote: > ...
4 years, 8 months ago (2016-04-14 16:56:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882243004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882243004/20001
4 years, 8 months ago (2016-04-14 16:56:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 17:37:15 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 17:38:23 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0569a0ed6347980265b437c61b5849ee2ca2c529
Cr-Commit-Position: refs/heads/master@{#387350}

Powered by Google App Engine
This is Rietveld 408576698