Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1882213002: Cleanup various IFX_ text interfaces. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup various IFX_ text interfaces. This CL removes IFX_ArabicChar, IFX_RTFBreak, IFX_TxtBreak, IFX_WordBreak, IFX_FormatString, and IFX_GSUBTable. References were updated to be the concrete classes. The CFX_GSUBTable was also removed as it is unused. BUG=pdfium:468 Committed: https://pdfium.googlesource.com/pdfium/+/17f382a50a7c4e5b6f14f76027a15de4ac17bc4c

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+478 lines, -930 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/ttgsubtable.h View 2 chunks +1 line, -7 lines 0 comments Download
M core/fpdfapi/fpdf_font/ttgsubtable.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
D core/fxcrt/fx_arabic.h View 1 chunk +0 lines, -211 lines 0 comments Download
M core/fxcrt/fx_arabic.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
A + core/fxcrt/include/fx_arabic.h View 6 chunks +23 lines, -39 lines 0 comments Download
M core/fxcrt/include/fx_arb.h View 2 chunks +0 lines, -17 lines 0 comments Download
M core/fxge/include/fx_font.h View 1 chunk +0 lines, -9 lines 0 comments Download
M pdfium.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fde/tto/fde_textout.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M xfa/fee/fde_txtedtengine.h View 3 chunks +4 lines, -3 lines 0 comments Download
M xfa/fee/fde_txtedtengine.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fee/fde_txtedtpage.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fee/fde_txtedtparag.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fee/fx_wordbreak/fx_wordbreak.h View 1 chunk +40 lines, -13 lines 0 comments Download
M xfa/fee/fx_wordbreak/fx_wordbreak_impl.h View 1 chunk +0 lines, -41 lines 0 comments Download
M xfa/fee/fx_wordbreak/fx_wordbreak_impl.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fgas/layout/fgas_rtfbreak.h View 2 chunks +159 lines, -41 lines 0 comments Download
M xfa/fgas/layout/fgas_rtfbreak.cpp View 2 chunks +2 lines, -170 lines 0 comments Download
M xfa/fgas/layout/fgas_textbreak.h View 2 chunks +158 lines, -42 lines 0 comments Download
M xfa/fgas/layout/fgas_textbreak.cpp View 1 2 chunks +2 lines, -167 lines 0 comments Download
M xfa/fgas/localization/fgas_locale.h View 1 chunk +0 lines, -52 lines 0 comments Download
M xfa/fgas/localization/fgas_locale.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M xfa/fgas/localization/fgas_localeimp.h View 1 chunk +48 lines, -48 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_localevalue.cpp View 5 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-12 20:26:38 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1882213002/diff/1/pdfium.gyp File pdfium.gyp (right): https://codereview.chromium.org/1882213002/diff/1/pdfium.gyp#newcode669 pdfium.gyp:669: 'core/fxcrt/include/fx_arabic.h', nit: order was wrong before your change. ...
4 years, 8 months ago (2016-04-12 20:58:20 UTC) #3
dsinclair
https://codereview.chromium.org/1882213002/diff/1/pdfium.gyp File pdfium.gyp (right): https://codereview.chromium.org/1882213002/diff/1/pdfium.gyp#newcode669 pdfium.gyp:669: 'core/fxcrt/include/fx_arabic.h', On 2016/04/12 20:58:19, Tom Sepez wrote: > nit: ...
4 years, 8 months ago (2016-04-12 23:36:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882213002/20001
4 years, 8 months ago (2016-04-12 23:36:21 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 23:55:59 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/17f382a50a7c4e5b6f14f76027a15de4ac17...

Powered by Google App Engine
This is Rietveld 408576698