Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Unified Diff: Source/core/page/Console.cpp

Issue 18822004: Extension Error Piping - Blink: WebKit Side (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/Console.cpp
diff --git a/Source/core/page/Console.cpp b/Source/core/page/Console.cpp
index bd34162ac01de4fa12be8ecbfa4529726f6c7d9f..969a281f96f613702607d179e0d3c95a16ea5e7f 100644
--- a/Source/core/page/Console.cpp
+++ b/Source/core/page/Console.cpp
@@ -42,6 +42,7 @@
#include "core/page/Frame.h"
#include "core/page/MemoryInfo.h"
#include "core/page/Page.h"
+#include "core/page/PageConsole.h"
#include "wtf/text/CString.h"
#include "wtf/text/WTFString.h"
@@ -69,16 +70,19 @@ static void internalAddMessage(Page* page, MessageType type, MessageLevel level,
if (!acceptNoArguments && !arguments->argumentCount())
return;
- size_t stackSize = printTrace ? ScriptCallStack::maxCallStackSizeToCapture : 1;
- RefPtr<ScriptCallStack> callStack(createScriptCallStack(state, stackSize));
- const ScriptCallFrame& lastCaller = callStack->at(0);
-
String message;
bool gotMessage = arguments->getFirstArgumentAsString(message);
InspectorInstrumentation::addMessageToConsole(page, ConsoleAPIMessageSource, type, level, message, state, arguments);
- if (gotMessage)
- page->chrome().client()->addMessageToConsole(ConsoleAPIMessageSource, type, level, message, lastCaller.lineNumber(), lastCaller.sourceURL());
+ String stackTrace;
+ if (gotMessage) {
+ RefPtr<ScriptCallStack> callStack(createScriptCallStack(state, 1));
+ if (page->chrome().client()->shouldReportDetailedMessageForSource(callStack->at(0).sourceURL())) {
+ callStack = createScriptCallStack(ScriptCallStack::maxCallStackSizeToCapture);
+ stackTrace = PageConsole::formatStackTraceString(message, callStack);
+ }
+ page->chrome().client()->addMessageToConsole(ConsoleAPIMessageSource, level, message, callStack->at(0).lineNumber(), callStack->at(0).sourceURL(), stackTrace);
+ }
}
void Console::debug(ScriptState* state, PassRefPtr<ScriptArguments> arguments)

Powered by Google App Engine
This is Rietveld 408576698