Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: Source/core/page/PageConsole.cpp

Issue 18822004: Extension Error Piping - Blink: WebKit Side (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/PageConsole.cpp
diff --git a/Source/core/page/PageConsole.cpp b/Source/core/page/PageConsole.cpp
index 07bbb252a6ce2974edde7df033fa5d860034e9b2..5a65b9f2931b32a9c820feb3e52aff1f02c76638 100644
--- a/Source/core/page/PageConsole.cpp
+++ b/Source/core/page/PageConsole.cpp
@@ -92,6 +92,21 @@ void PageConsole::addMessage(MessageSource source, MessageLevel level, const Str
return;
page->chrome().client()->addMessageToConsole(source, level, message, lineNumber, url);
+ if (page->chrome().client()->shouldReportDetailedMessage(url)) {
+ String jsonStackTrace;
+ if (callStack) {
+ jsonStackTrace = callStack->buildInspectorArray()->toJSONString();
+ } else {
+ RefPtr<JSONObject> simpleStackFrame = JSONObject::create();
+ simpleStackFrame->setNumber("lineNumber", lineNumber);
+ simpleStackFrame->setNumber("columnNumber", columnNumber);
+ simpleStackFrame->setString("url", url);
+ RefPtr<JSONArray> simpleStackTrace = JSONArray::create();
+ simpleStackTrace->pushObject(simpleStackFrame);
+ jsonStackTrace = simpleStackTrace->toJSONString();
+ }
+ page->chrome().client()->reportDetailedMessage(url, level, message, jsonStackTrace);
+ }
}
// static

Powered by Google App Engine
This is Rietveld 408576698