Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Unified Diff: Source/core/page/FormatConsoleMessage.h

Issue 18822004: Extension Error Piping - Blink: WebKit Side (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Extracted Formatting Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/FormatConsoleMessage.h
diff --git a/Source/modules/webmidi/MIDIClient.h b/Source/core/page/FormatConsoleMessage.h
similarity index 80%
copy from Source/modules/webmidi/MIDIClient.h
copy to Source/core/page/FormatConsoleMessage.h
index 5c797c4fb22a1b126728355b4f091546ec007d5f..13fdac0e2b917945731ec5f1a9ea83f400240775 100644
--- a/Source/modules/webmidi/MIDIClient.h
+++ b/Source/core/page/FormatConsoleMessage.h
@@ -28,27 +28,21 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef MIDIClient_h
-#define MIDIClient_h
+#ifndef FormatConsoleMessage_h
+#define FormatConsoleMessage_h
#include "wtf/PassRefPtr.h"
-namespace WebCore {
-
-class MIDIAccess;
-class Page;
+namespace WTF {
+class String;
+} // namespace WTF
-class MIDIClient {
-public:
- virtual void requestSysExPermission(PassRefPtr<MIDIAccess>) = 0;
- virtual void cancelSysExPermissionRequest(MIDIAccess*) = 0;
-
-protected:
- virtual ~MIDIClient() { }
-};
+namespace WebCore {
+class ScriptCallStack;
-void provideMIDITo(Page*, MIDIClient*);
+WTF::String formatConsoleMessage(const WTF::String& originalMessage, PassRefPtr<ScriptCallStack>);
pfeldman 2013/08/14 09:53:00 It was fine to make it static on PageConsole.
Devlin 2013/08/14 17:00:40 Okay. Moved there.
+WTF::String formatConsoleMessage(const WTF::String& originalMessage, const WTF::String& url, unsigned lineNumber, unsigned columnNumber);
} // namespace WebCore
-#endif // MIDIClient_h
+#endif // FormatConsoleMessage_h

Powered by Google App Engine
This is Rietveld 408576698