Source/core/page/ChromeClient.h - Issue 18822004: Extension Error Piping - Blink: WebKit Side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/ChromeClient.h

Issue 18822004: Extension Error Piping - Blink: WebKit Side (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Pass in plain text, per Pavel's suggestion Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/ChromeClient.h

diff --git a/Source/core/page/ChromeClient.h b/Source/core/page/ChromeClient.h

index d97cbff82dd2f8663cd91d98599ddfa8a59b4d99..6f7ce727542db37e50307c876655c30498c30066 100644

--- a/Source/core/page/ChromeClient.h

+++ b/Source/core/page/ChromeClient.h

@@ -125,6 +125,7 @@ public:

virtual void setResizable(bool) = 0;

+ virtual bool shouldReportDetailedMessageForSource(const String&) = 0;

virtual void addMessageToConsole(MessageSource, MessageLevel, const String& message, unsigned lineNumber, const String& sourceID) = 0;

// FIXME: Remove this MessageType variant once all the clients are updated.

virtual void addMessageToConsole(MessageSource source, MessageType, MessageLevel level, const String& message, unsigned lineNumber, const String& sourceID)

« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/page/Console.cpp » ('j') | Source/core/page/Console.cpp » ('J')