Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: Source/core/page/PageConsole.cpp

Issue 18822004: Extension Error Piping - Blink: WebKit Side (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Use v8 Contexts Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/PageConsole.cpp
diff --git a/Source/core/page/PageConsole.cpp b/Source/core/page/PageConsole.cpp
index 07bbb252a6ce2974edde7df033fa5d860034e9b2..9545ab064e804d96867e11403420626e3ae66bc5 100644
--- a/Source/core/page/PageConsole.cpp
+++ b/Source/core/page/PageConsole.cpp
@@ -91,7 +91,15 @@ void PageConsole::addMessage(MessageSource source, MessageLevel level, const Str
if (source == CSSMessageSource)
return;
- page->chrome().client()->addMessageToConsole(source, level, message, lineNumber, url);
+ String details;
+ if (page->chrome().client()->shouldReportDetailedMessage(state ? state->context() : v8::Handle<v8::Context>(), url)) {
+ String executionContextURL = page->mainFrame()->document()->url().string();
+ if (callStack)
+ details = page->chrome().generateConsoleMessageDetails(callStack, executionContextURL);
+ else
+ details = page->chrome().generateConsoleMessageDetails(lineNumber, columnNumber, url, "", executionContextURL);
+ }
+ page->chrome().client()->addMessageToConsole(source, level, message, lineNumber, url, details);
}
// static

Powered by Google App Engine
This is Rietveld 408576698